1441761 - HAR: entry.time is null

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect, P3)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

entry.time value is not properly exported from the Net panel.

Originally reported here:
https://github.com/devtools-html/har-export-trigger/issues/11

Honza

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Also reported here:
https://github.com/janodvarko/harviewer/issues/109

Honza

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: Bug 1441761 - Properly export total time;

Review commit: https://reviewboard.mozilla.org/r/225744/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/225744/

Comment 3

[Alexandre Poirot [:ochameau]]

Comment on attachment 8956778 [details]
Bug 1441761 - Properly export total time;

https://reviewboard.mozilla.org/r/225744/#review231634

Looks good, thanks.

Should we also remove this?
https://searchfox.org/mozilla-central/source/devtools/client/netmonitor/src/har/har-collector.js#389
endedMillis doesn't seem to be used anywhere.

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8956778 [details]
Bug 1441761 - Properly export total time;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/225744/diff/1-2/

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to Alexandre Poirot [:ochameau] from comment #3)
> Should we also remove this?
> https://searchfox.org/mozilla-central/source/devtools/client/netmonitor/src/
> har/har-collector.js#389
> endedMillis doesn't seem to be used anywhere.
Good point, done.

Honza

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/895b03babc03
Properly export total time; r=ochameau

Comment 7

[Andreea Pavel [:apavel]]

Backed out for failing mochitest at devtools/client/netmonitor/src/har/test/browser_net_har_import.js

Push that caused the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=895b03babc03b3e155736fb9bb1055ec697e490e

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=166532253&repo=autoland&lineNumber=9808

Backout: https://hg.mozilla.org/integration/autoland/rev/139c87db9eae3dc403317356b677d39ff8088d4e

Comment 8

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8956778 [details]
Bug 1441761 - Properly export total time;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/225744/diff/2-3/

Comment 9

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Problem fixed. The exported time must be sum of all timings not `file.totalTime` that doesn't have to always be equal to the sum. A comment added to the code.

Honza

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/92acb000423a
Properly export total time; r=ochameau

Comment 11

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/92acb000423a