1441766 - Cookies and site data search keywords aren't optimal

Status: RESOLVED FIXED

(Firefox :: Settings UI, enhancement, P1)

Description

[Johann Hofmann [:johannh]]

If you search for e.g. "third party" it will still direct you to the History menu. There are some other search strings that aren't well adjusted either.

Comment 1

[Johann Hofmann [:johannh]]

Attachment: Bug 1441766 - Fix search keywords for site data and cookies in about:preferences.

When moving cookies to the site data section we forgot about some
searchkeywords which were left on the cookies exceptions dialog.

We also forgot to remove the status column label when removing the
status column.

Further, the search tooltip is not displayed correctly on the three
vertically aligned dialog buttons (it's always on the last button),
because we did not put each of them in its own hbox (which is just way
too easy to get wrong and needs a better mid term solution).

Review commit: https://reviewboard.mozilla.org/r/223814/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/223814/

Comment 2

[Johann Hofmann [:johannh]]

Comment on attachment 8954692 [details]
Bug 1441766 - Fix search keywords for site data and cookies in about:preferences.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/223814/diff/1-2/

Comment 3

[Johann Hofmann [:johannh]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c4210201ef682c05fd66838f0aa1cd9dc7a7a680

Comment 4

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 8954692 [details]
Bug 1441766 - Fix search keywords for site data and cookies in about:preferences.

https://reviewboard.mozilla.org/r/223814/#review229864

Comment 5

[Johann Hofmann [:johannh]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=23025586a5c47018ddc56e4f6a57b6ff2b4fac53

Comment 6

[Johann Hofmann [:johannh]]

Attachment: Add a test for searching in the site data group. r=nhnt11

These are the test improvements. Sorry, they had to come as a regular patch because mozreview can't deal with me working on a series of patches that have two different bugs...

Comment 7

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 8954767 [details] [diff] [review]
Add a test for searching in the site data group. r=nhnt11

Review of attachment 8954767 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, assuming the tests pass :D

Comment 8

[Johann Hofmann [:johannh]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/161a8e168596d92afa8c7f0c3bc46e185e2ee540
Bug 1441766 - Fix search keywords for site data and cookies in about:preferences. r=nhnt11

https://hg.mozilla.org/integration/mozilla-inbound/rev/13702241dca9ebf766973e607d1f3dee600de69b
Bug 1441766 - Add a test for searching in the site data group. r=nhnt11

Comment 9

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/161a8e168596
https://hg.mozilla.org/mozilla-central/rev/13702241dca9