Open Bug 1441785 Opened 2 years ago Updated 6 months ago

Improve performance of VisibilityHelper

Categories

(DevTools :: Framework, enhancement, P2)

enhancement

Tracking

(Not tracked)

People

(Reporter: Honza, Unassigned)

References

(Blocks 1 open bug)

Details

This is a follow up for bug 1419350

Visibility helper is nicely improving the performance by avoiding useless re-rendering if a panel is running in background.

But, React is still spending significant time when state changes. It would be great if we could disconnect components from Redux store temporarily and safe even more CPU cycles.

---

From this comment:
https://bugzilla.mozilla.org/show_bug.cgi?id=1419350#c26

The vast majority of react.js is delegated to react-dom.js:enqueueSetState 
By looking at the stacks, it looks like it is only to update the VisibilityHandler component.
We can see its shouldComponentUpdate method being called.
Then comes reselect and all the filter function, we spend 34ms in them.

Honza
Severity: normal → enhancement
Priority: -- → P2
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.