Closed Bug 1441789 Opened 6 years ago Closed 6 years ago

Add automated test to check that websites can be bookmarked via URL drag & drop onto the Bookmarks Toolbar and Sidebar

Categories

(Firefox :: Bookmarks & History, enhancement, P3)

enhancement

Tracking

()

RESOLVED INCOMPLETE

People

(Reporter: pauly, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxsearch])

TestRail links:

Test 1:
https://testrail.stage.mozaws.net/index.php?/cases/view/4090

Steps
1. Launch Firefox.
2. Enable the Bookmarks Toolbar.
3. Open a website that's currently not in your bookmarks list.
4. Drag and drop the website's URL from the Location Bar onto the Bookmarks Toolbar.

Expected results:
1. Firefox is successfully launched.
2. The Bookmarks Toolbar is enabled and displayed below the Location Bar.
3. The website is properly loaded.
4. The star-shaped button changes its color to blue and the website is successfully placed onto the Bookmarks Toolbar, displaying the correct name.


Test 2:
https://testrail.stage.mozaws.net/index.php?/cases/view/4092

Steps
1. Launch Firefox.
2. Open a website that's currently not in your bookmarks list.
3. Enable the Bookmarks Sidebar.
4. Expand the Bookmarks Toolbar entry from the sidebar.
5. Drag and drop the website's URL from the Location Bar into the Bookmarks Toolbar sidebar entry.

Expected results:
1. Firefox is successfully launched.
2. The website is properly loaded.
3. The Bookmarks Sidebar is enabled and displayed at the left side.
4. The Bookmarks Toolbar entry is expanded.
5. The star-shaped button changes its color to blue and the website is successfully placed at the buttom of the list displayed by the Bookmarks Toolbar entry in the sidebar. 
The bookmark displays the correct website name.
Hi Mark,
Do you think Test 1 is covered by https://dxr.mozilla.org/mozilla-central/source/browser/components/places/tests/browser/browser_toolbar_drop_text.js, since the actual data for the drop is passed via the drag data and the drag source isn't so important?
Flags: needinfo?(standard8)
(In reply to Paul Silaghi, QA [:pauly] from comment #1)
> Hi Mark,
> Do you think Test 1 is covered by
> https://dxr.mozilla.org/mozilla-central/source/browser/components/places/
> tests/browser/browser_toolbar_drop_text.js, since the actual data for the
> drop is passed via the drag data and the drag source isn't so important?

Yeah, I think that's fine at the moment. Drag and drop is really hard for tests to simulate/do properly, so we do the best we can.
Flags: needinfo?(standard8)
Priority: -- → P3
Whiteboard: [fxsearch]
Dropping this for now due to other high priority tasks.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.