1441817 - Browser console throws on console.count in content tab

Status: RESOLVED FIXED

(DevTools :: Console, defect, P1)

Description

[Nicolas Chevobbe [:nchevobbe]]

**Steps to reproduce**
1. Open the browser console
2. Open the following in a content tab: data:text/html,<meta charset=utf8><script>console.count("content")</script>


**Expected results**

I get a "content: 1" message (or at least, something telling me why I can't access the counter)

**Actual results**

There's an error in the terminal:

> JavaScript error: resource://devtools/shared/base-loader.js -> resource://devtools/client/webconsole/new-console-output/utils/messages.js, line 94: TypeError: counter is undefined

---

This indicates an error in the frontend [1] which should be easy to fix. But it would be good to see why we have a different packet than in the webconsole.


[1] https://searchfox.org/mozilla-central/rev/14d933246211b02f5be21d2e730a57cf087c6606/devtools/client/webconsole/new-console-output/utils/messages.js#85-92

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Here's the packet we get in the browser console: 

```json
{
  "from": "server1.conn0.consoleActor2",
  "type": "consoleAPICall",
  "message": {
    "level": "count",
    "filename": "data:text/html,<meta%20charset=utf8><script>console.count(\"content\")</script>",
    "lineNumber": 1,
    "functionName": "",
    "timeStamp": 1519828532755,
    "addonId": "",
    "arguments": [
      "content"
    ],
    "workerType": "none",
    "styles": [],
    "category": "webdev"
  }
}
```

Note that we don't have a counter argument at all.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1441817 - Fix Error when console.count packet is incomplete; .

This currently happens in the browser console. The packet we receive
for console.count calls does not have the counter property which we
usually consume to display the counter label and data.
Here we prevent adding such messages, before a follow-up fix which should
be about adding those information in the packet.
For the record, it was not working either in the old frontend.

Review commit: https://reviewboard.mozilla.org/r/223890/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/223890/

Comment 3

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8954757 [details]
Bug 1441817 - Fix Error when console.count packet is incomplete; .

https://reviewboard.mozilla.org/r/223890/#review232346

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e29b54201696
Fix Error when console.count packet is incomplete; r=miker.

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/e29b54201696

Comment 6

[Tom Bannister]

I was unable to reproduce this issue on Firefox 59.0.3 (20180427210249) on Windows 10x64, Firefox 60.0b16 (20180426170554) on Windows 10x64 or on Firefox Nightly 61.0a1 (20180503220110) on Windows 10x64.

[bugday-20180502]