Closed Bug 1441833 Opened 3 years ago Closed 3 years ago

Stop using fill: GrayText in panels

Categories

(Firefox :: Theme, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 60
Tracking Status
firefox60 --- fixed

People

(Reporter: ntim, Assigned: ntim)

References

Details

Attachments

(1 file)

No description provided.
Blocks: 1408121
Comment on attachment 8954741 [details]
Bug 1441833 - Stop using fill: GrayText in panels.

https://reviewboard.mozilla.org/r/223878/#review232314

::: browser/themes/shared/customizableui/panelUI.inc.css:1543
(Diff revision 1)
>  }
>  
>  .subviewbutton.download > .action-button {
>    -moz-appearance: none; /* To avoid native Windows hover styling */
> -  -moz-context-properties: fill;
> +  -moz-context-properties: fill, fill-opacity;
>    fill: currentColor;

Should probably set fill-opacity: 1 here in case a parent sets fill-opacity for some reason.

::: browser/themes/shared/customizableui/panelUI.inc.css:1560
(Diff revision 1)
>    list-style-image: url("chrome://browser/skin/reload.svg");
>  }
>  
>  .subviewbutton.download:not([openLabel]):not([retryLabel]) > .action-button {
> -  fill: GrayText;
> -  opacity: .5;
> +  fill: currentColor;
> +  fill-opacity: 0.3;

We usually use 0.4 for this kind of thing, right?
Attachment #8954741 - Flags: review?(dao+bmo) → review+
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/5110a382f6a0
Stop using fill: GrayText in panels. r=dao
https://hg.mozilla.org/mozilla-central/rev/5110a382f6a0
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
Depends on: 1449897
You need to log in before you can comment on or make changes to this bug.