1441833 - Stop using fill: GrayText in panels

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Comment 1

[Tim Nguyen :ntim]

Attachment: Bug 1441833 - Stop using fill: GrayText in panels.

Review commit: https://reviewboard.mozilla.org/r/223878/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/223878/

Comment 2

[Dão Gottwald [:dao]]

Comment on attachment 8954741 [details]
Bug 1441833 - Stop using fill: GrayText in panels.

https://reviewboard.mozilla.org/r/223878/#review232314

::: browser/themes/shared/customizableui/panelUI.inc.css:1543
(Diff revision 1)
>  }
>  
>  .subviewbutton.download > .action-button {
>    -moz-appearance: none; /* To avoid native Windows hover styling */
> -  -moz-context-properties: fill;
> +  -moz-context-properties: fill, fill-opacity;
>    fill: currentColor;

Should probably set fill-opacity: 1 here in case a parent sets fill-opacity for some reason.

::: browser/themes/shared/customizableui/panelUI.inc.css:1560
(Diff revision 1)
>    list-style-image: url("chrome://browser/skin/reload.svg");
>  }
>  
>  .subviewbutton.download:not([openLabel]):not([retryLabel]) > .action-button {
> -  fill: GrayText;
> -  opacity: .5;
> +  fill: currentColor;
> +  fill-opacity: 0.3;

We usually use 0.4 for this kind of thing, right?

Comment 3

[Tim Nguyen :ntim]

Comment on attachment 8954741 [details]
Bug 1441833 - Stop using fill: GrayText in panels.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/223878/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5110a382f6a0
Stop using fill: GrayText in panels. r=dao

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/5110a382f6a0