Stop using fill: GrayText in panels

RESOLVED FIXED in Firefox 60

Status

()

defect
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: ntim, Assigned: ntim)

Tracking

unspecified
Firefox 60
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox60 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

a year ago
No description provided.
Comment hidden (mozreview-request)
Assignee

Updated

a year ago
Blocks: 1408121

Comment 2

a year ago
mozreview-review
Comment on attachment 8954741 [details]
Bug 1441833 - Stop using fill: GrayText in panels.

https://reviewboard.mozilla.org/r/223878/#review232314

::: browser/themes/shared/customizableui/panelUI.inc.css:1543
(Diff revision 1)
>  }
>  
>  .subviewbutton.download > .action-button {
>    -moz-appearance: none; /* To avoid native Windows hover styling */
> -  -moz-context-properties: fill;
> +  -moz-context-properties: fill, fill-opacity;
>    fill: currentColor;

Should probably set fill-opacity: 1 here in case a parent sets fill-opacity for some reason.

::: browser/themes/shared/customizableui/panelUI.inc.css:1560
(Diff revision 1)
>    list-style-image: url("chrome://browser/skin/reload.svg");
>  }
>  
>  .subviewbutton.download:not([openLabel]):not([retryLabel]) > .action-button {
> -  fill: GrayText;
> -  opacity: .5;
> +  fill: currentColor;
> +  fill-opacity: 0.3;

We usually use 0.4 for this kind of thing, right?
Attachment #8954741 - Flags: review?(dao+bmo) → review+
Comment hidden (mozreview-request)

Comment 4

a year ago
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/5110a382f6a0
Stop using fill: GrayText in panels. r=dao

Comment 5

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/5110a382f6a0
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
Assignee

Updated

a year ago
Depends on: 1449897
You need to log in before you can comment on or make changes to this bug.