1441841 - User reviews count from Add-ons manager is inconsistent with the new AMO frontend

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Alexandra Moga [:LexaSV]]

Attachment: reviews count

[Affected versions]:
- Firefox 60.0a1 (20180227221355)

[Affected platforms]:
- Win 10 64-bit
- Mac OS X 10.13.2
- Ubuntu 12.04 64-bit

[Steps to reproduce]:
1.Install the following add-on from AMO: https://addons-dev.allizom.org/en-US/firefox/addon/reloaded-addon/
2.After the installation is complete, go to about:addons and check the installed add-on in the Extensions tab.
3.Click on 'More' to see the extension details and observe the number of reviews displayed
4.Click on <# reviews> link to read all the reviews associated with this add-on.


[Expected results]:
- The reviews number observed in addons manager should match the actual written reviews from AMO. The new API should allow the option to ignore empty reviews.

[Actual results]:
- The number of reviews from addons manager is inconsistent  with the number displayed in AMO reviews page.

Notes:
- originally filed here - https://github.com/mozilla/addons-server/issues/7557

Comment 1

[Andrew Swan [:aswan]]

Attachment: Bug 1441841 Use the right count for ratings link in addon details

Review commit: https://reviewboard.mozilla.org/r/224150/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/224150/

Comment 2

[Andrew Williamson [:eviljeff]]

Comment on attachment 8954963 [details]
Bug 1441841 Use the right count for ratings link in addon details

https://reviewboard.mozilla.org/r/224150/#review230158

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ce11f5286651
Use the right count for ratings link in addon details r=eviljeff

Comment 4

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/ce11f5286651

Comment 5

[Alexandra Moga [:LexaSV]]

Attachment: verified-rev-count.gif

Comment 6

[Alexandra Moga [:LexaSV]]

This is working now. Verified on Windows 10x64 with Firefox 60.0a1 (latest).

Comment 7

[Anca Soncutean [:Anca], Desktop Release QA]

Attachment: screencast issue.mp4

I can reproduce this issue with the latest Beta build - 66.0b5 on Windows 10 x64 (see the attached screencast).
As far as I know AMO changed its policies on this matter, now even reviews without text are displayed, not sure if this is relevant for the recurrence of this behavior. Should I fill a separate bug?

Comment 8

[Alexandra Moga [:LexaSV]]

To bring some background into this, AMO has done some recent changes to review listing - see issue https://github.com/mozilla/addons-frontend/issues/7200

At the moment this issue was marked as verified fixed, the behavior was correct.

Comment 9

[Andrew Swan [:aswan]]

If we need to change something in the browser, please open a new issue.