Remove unused --chrome-nav-bar-separator-color variable

RESOLVED FIXED in Firefox 61

Status

()

enhancement
P3
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: jaws, Assigned: uoftcsc, Mentored)

Tracking

({good-first-bug})

unspecified
Firefox 61
Points:
---

Firefox Tracking Flags

(firefox61 fixed)

Details

(Whiteboard: [lang=css])

Attachments

(1 attachment)

The last reference to this was removed by bug 1349555.
Bug 1441882 added a test that catches these types of errors. When fixing this, the entry for this bug will need to be removed from the whitelist in browser_parsable_css.js.
https://searchfox.org/mozilla-central/search?q=chrome-nav-bar-separator-color&case=true&path=
Mentor: dao+bmo
Keywords: good-first-bug
Summary: --chrome-nav-bar-separator-color is defined but not referenced → Remove unused --chrome-nav-bar-separator-color variable
Whiteboard: [lang=css]
Priority: -- → P3
(Assignee)

Comment 3

a year ago
I'd like to work on this
(In reply to Jon K from comment #3)
> I'd like to work on this

Go ahead. :) Have you built Firefox yet? Do you know what files to modify and how to submit a patch?
(Assignee)

Comment 5

a year ago
(In reply to Dão Gottwald [::dao] from comment #4)
> (In reply to Jon K from comment #3)
> > I'd like to work on this
> 
> Go ahead. :) Have you built Firefox yet? Do you know what files to modify
> and how to submit a patch?

Yes and I believe so. I will report back if I run into any problems.
Can I work on this?
(In reply to paarmita1998 from comment #6)
> Can I work on this?

I'm not sure if Jon is still working on this. Jon?
Flags: needinfo?(uoftcsc)
(Assignee)

Comment 8

a year ago
(In reply to Dão Gottwald [::dao] from comment #7)
> (In reply to paarmita1998 from comment #6)
> > Can I work on this?
> 
> I'm not sure if Jon is still working on this. Jon?

Yes, I will attach the patch within a day.
Flags: needinfo?(uoftcsc)
(Assignee)

Comment 9

a year ago
This is my first patch, please let me know if there are any issues I should change.
Comment on attachment 8958336 [details] [diff] [review]
Bug 1441844: Remove unused --chrome-nav-bar-separator-color variable

Perfect, thanks!
Attachment #8958336 - Flags: review+
Assignee: nobody → uoftcsc

Comment 11

a year ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f1e6aeb55b95
Remove unused --chrome-nav-bar-separator-color variable. r=dao

Comment 12

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/f1e6aeb55b95
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
You need to log in before you can comment on or make changes to this bug.