Closed
Bug 1441878
Opened 6 years ago
Closed 6 years ago
--theme-codemirror-gutter-background is defined but never referenced
Categories
(DevTools :: Debugger, defect)
DevTools
Debugger
Tracking
(firefox63 fixed)
RESOLVED
FIXED
Firefox 63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: jaws, Assigned: jdescottes)
References
Details
Attachments
(1 file)
It looks like this property was added as part of bug 1383803 but was never referenced.
Flags: needinfo?(jlaster)
|
||
Comment 1•6 years ago
|
||
Thanks, I added it to bug: https://github.com/devtools-html/debugger.html/issues/5566
Flags: needinfo?(jlaster)
|
Reporter | |
Comment 2•6 years ago
|
||
Bug 1441882 added a test that catches these types of errors. When fixing this, the entry for this bug will need to be removed from the whitelist in browser_parsable_css.js.
|
|
Reporter | |
Comment 3•6 years ago
|
||
Fixed per github issue.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
|
||
Comment 4•6 years ago
|
||
This property is still present in m-c: https://searchfox.org/mozilla-central/search?q=--theme-codemirror-gutter-background&case=false®exp=false&path=
Status: RESOLVED → REOPENED
Flags: needinfo?(jlaster)
Resolution: FIXED → ---
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
|
Assignee | |
Comment 5•6 years ago
|
||
This variable is no longer used anywhere and can be removed
|
|
||
Comment 6•6 years ago
|
||
Comment on attachment 9004142 [details] Bug 1441878 - Remove unused css variable theme-codemirror-gutter-background;r=ntim Tim Nguyen :ntim has approved the revision.
Attachment #9004142 -
Flags: review+
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a0736ba18fe4 Remove unused css variable theme-codemirror-gutter-background;r=ntim
|
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → jdescottes
Status: REOPENED → ASSIGNED
|
||
Comment 8•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/a0736ba18fe4
Status: ASSIGNED → RESOLVED
Closed: 6 years ago → 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
|
|
||
Updated•6 years ago
|
Flags: needinfo?(jlaster)
You need to log in
before you can comment on or make changes to this bug.
Description
•