Closed Bug 1441920 Opened 2 years ago Closed 2 years ago

Snap - Startup time is slow after install and update

Categories

(Release Engineering :: Release Automation: Other, defect)

defect
Not set

Tracking

(firefox60 fixed)

RESOLVED FIXED
Tracking Status
firefox60 --- fixed

People

(Reporter: ken.vandine, Assigned: ken.vandine)

References

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Ubuntu Chromium/65.0.3325.88 Chrome/65.0.3325.88 Safari/537.36

Steps to reproduce:

On first run after install or update the firefox snap takes ~30 seconds to start.
We can easily improve this by running update-mime-database at the end of the build rather than on startup.
Comment on attachment 8954836 [details]
Bug 1441920 - Run update-mime-database at the end of the build rather than on startup of the snap

https://reviewboard.mozilla.org/r/223996/#review229996

Thanks for this perf huge improvement! Let's check the naming and the `set -x` before landing. Otherwise, the rest LGTM.

::: taskcluster/docker/firefox-snap/snapcraft.yaml.in:55
(Diff revision 1)
>        - desktop-file-utils
>        - xdg-utils
>        - ffmpeg
>      after: [desktop-gtk3]
> +
> +  magic:

Nit: Per our discussion on IRC, the name is free-form. Then, I'd suggest to name it something like "database-optimization"

::: taskcluster/docker/firefox-snap/snapcraft.yaml.in:61
(Diff revision 1)
> +    after: [firefox]
> +    plugin: nil
> +    stage-packages:
> +      - shared-mime-info
> +    install: |
> +      set -eux

I doubt it, but is there a change "-x" leaks any secret?
Attachment #8954836 - Flags: review?(jlorenzo)
Comment on attachment 8954836 [details]
Bug 1441920 - Run update-mime-database at the end of the build rather than on startup of the snap

https://reviewboard.mozilla.org/r/223996/#review229996

> I doubt it, but is there a change "-x" leaks any secret?

The -x just prints the commands being run.  This is very useful in the build logs.
Comment on attachment 8954836 [details]
Bug 1441920 - Run update-mime-database at the end of the build rather than on startup of the snap

https://reviewboard.mozilla.org/r/223996/#review230004
Attachment #8954836 - Flags: review?(jlorenzo) → review+
Pushed by jlorenzo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ca2b32cb6509
Run update-mime-database at the end of the build rather than on startup of the snap r=jlorenzo
https://hg.mozilla.org/mozilla-central/rev/ca2b32cb6509
Status: UNCONFIRMED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Assignee: nobody → ken.vandine
Blocks: snappy
You need to log in before you can comment on or make changes to this bug.