1441931 - Use open_url provided by Pocket for 'saved to pocket' items in highlights

Status: RESOLVED FIXED

(Firefox :: New Tab Page, enhancement, P1)

Comment 1

[Ursula Sarracini (:ursula)]

Attachment: Bug 1441931 - Use open_url provided by Pocket for 'saved to pocket' items in highlights

Review commit: https://reviewboard.mozilla.org/r/224018/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/224018/

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4009

Comment 3

[Ed Lee :Mardak]

Comment on attachment 8954871 [details]
Bug 1441931 - Use open_url provided by Pocket for 'saved to pocket' items in highlights

https://reviewboard.mozilla.org/r/224018/#review230076

I suppose having both url and open_url allows us to do something different, but any reason not to just set the url to be open_url?

Comment 4

[Ed Lee :Mardak]

In particular, there's also a given_url in the response but we were using resolved_url instead. So similarly, out of the 3 urls, we could have just picked one?

Comment 5

[Ursula Sarracini (:ursula)]

I think we should keep it for things like blocking, or deduping, or other things in the future that requires us knowing what that original url is. 
In terms of given_url vs resolved_url, I think that's if that was something like a bitly or a shortened url so that's not super useful for us, so we can rely on the resolved_url the most

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3fd23562098f
Use open_url provided by Pocket for 'saved to pocket' items in highlights r=Mardak

Comment 7

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/3fd23562098f

Comment 8

[[github robot]]

Commits pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/2456b044cc1057d3de62ccd906cc84abe0954545
Fix Bug 1441931 - Use open_url provided by Pocket for 'saved to pocket' items in highlights

https://github.com/mozilla/activity-stream/commit/e801647709ddbafd96c02cef2889bd9e56a53076
Merge pull request #4009 from sarracini/open_url

Fix Bug 1441931 - Use open_url provided by Pocket for 'saved to pocket' items in highlights