Closed Bug 1441931 Opened 4 years ago Closed 4 years ago

Use open_url provided by Pocket for 'saved to pocket' items in highlights

Categories

(Firefox :: New Tab Page, enhancement, P1)

57 Branch
enhancement

Tracking

()

RESOLVED FIXED
Firefox 60
Iteration:
60.4 - Mar 12
Tracking Status
firefox60 --- fixed

People

(Reporter: ursula, Assigned: ursula)

Details

Attachments

(2 files)

No description provided.
Summary: Use open_url provided by Pocket for 'saved to pocket' items in higlights → Use open_url provided by Pocket for 'saved to pocket' items in highlights
Comment on attachment 8954871 [details]
Bug 1441931 - Use open_url provided by Pocket for 'saved to pocket' items in highlights

https://reviewboard.mozilla.org/r/224018/#review230076

I suppose having both url and open_url allows us to do something different, but any reason not to just set the url to be open_url?
Attachment #8954871 - Flags: review?(edilee) → review+
In particular, there's also a given_url in the response but we were using resolved_url instead. So similarly, out of the 3 urls, we could have just picked one?
I think we should keep it for things like blocking, or deduping, or other things in the future that requires us knowing what that original url is. 
In terms of given_url vs resolved_url, I think that's if that was something like a bitly or a shortened url so that's not super useful for us, so we can rely on the resolved_url the most
Pushed by usarracini@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3fd23562098f
Use open_url provided by Pocket for 'saved to pocket' items in highlights r=Mardak
https://hg.mozilla.org/mozilla-central/rev/3fd23562098f
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
Commits pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/2456b044cc1057d3de62ccd906cc84abe0954545
Fix Bug 1441931 - Use open_url provided by Pocket for 'saved to pocket' items in highlights

https://github.com/mozilla/activity-stream/commit/e801647709ddbafd96c02cef2889bd9e56a53076
Merge pull request #4009 from sarracini/open_url

Fix Bug 1441931 - Use open_url provided by Pocket for 'saved to pocket' items in highlights
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.