1441938 - The project_bound_router is not needed and cumbersome in some cases

Status: RESOLVED WONTFIX

(Tree Management :: Treeherder: API, enhancement, P3)

Description

[Cameron Dawson [:camd]]

In the case of fetching a single job by ``id`` you shouldn't need to provide the project (repoName) from the UI, since the ids are unique across all repos.  We should explore removing this router and passing in the ``repo`` as a parameter where needed.

Comment 1

[Cameron Dawson [:camd]]

We could do this in stages. Start with the two main endpoints Job and Push:

1. Make the existing Viewsets not use the project param, if they don't need it. Or possibly convert ones like Push.list to take it as a query string param.
2. Make the UI pass 'default' or something as the project param for those apis.
3. Make a parallel version of the Viewset on the default_router in DRF.

The one sticking point is any API customers who rely on the old format. Maybe it's possible to have a router that then calls the default router without that project API path element, or converts it to a query_string param where needed.

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/4886

Comment 3

[Cameron Dawson [:camd]]

De-prioritizing Treeherder work in new reorg. So removing myself.

Comment 4

[Sarah Clements [:sclements]]

Not a priority.