Closed Bug 1441939 Opened 6 years ago Closed 6 years ago

Port bug 1439766 to viewSource.xul: Replace editMenuOverlay.xul by inlining and preprocessing

Categories

(Thunderbird :: General, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 60.0

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file, 1 obsolete file)

Bug 1439766 removed the editMenuOverlay.xul. viewSource.xul is the only TB file  that uses this overlay.
Attached patch viewSourse.patch (obsolete) — Splinter Review
This fixes the Edit menu.

It can be, without patch, you see still the menu on your build. This is because the editMenuOverlay.xul file isn't removed in your obj-dir. You can either remove it manually or do a clobber.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8954847 - Flags: review?(jorgk)
Can you do me a favour: See whether we can remove
https://hg.mozilla.org/comm-central/rev/2caecab6e8c041a4379cb706ae921d083b7456ed#l6.92
and instead put the refecence back:
https://hg.mozilla.org/mozilla-central/rev/fcfdf000a8f3#l14.21

I didn't know that you can reference global/locale DTD files like in your patch. So I messed that up when forking. Or is that not worth the worry?
Attached patch viewSourse.patchSplinter Review
Removed and added what you asked. There are also a lot of trailing whitespace removals in the dtd file.
Attachment #8954847 - Attachment is obsolete: true
Attachment #8954847 - Flags: review?(jorgk)
Attachment #8954867 - Flags: review?(jorgk)
Comment on attachment 8954867 [details] [diff] [review]
viewSourse.patch

Thanks!
Attachment #8954867 - Flags: review?(jorgk) → review+
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/5e07cff9cd9c
Port bug 1439766 to viewSource.xul: Replace editMenuOverlay.xul by inlining and pre-processing. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 60.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: