Closed Bug 1441978 Opened 8 years ago Closed 8 years ago

Run tests for taskcluster-login in Taskcluster

Categories

(Taskcluster :: Services, enhancement)

Product:
Taskcluster
Component:
Services
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: dustin, Assigned: hritvi2801, Mentored)

Details

The https://github.com/taskcluster/taskcluster-login/ service currently uses Travis-CI to do its testing. Instead, it should run its tests using taskcluster-github (https://docs.taskcluster.net/manual/using/github), and stop using Travis-CI. To get started on this, fork the repository and get taskcluster-github set up for your repository, then write a .taskcluster.yml that runs the tests. Once that's working, make a pull request to add that .taskcluster.yml to the original repository.
Hii Dustin, I would like to work on this, thank you!
Flags: needinfo?(dustin)
I have forked this repository and also added .taskcluster.yml file in a new branch in my forked repository.I am facing a problem on how to run this.Thanks
The quick-start has a way to enable the Github app for your repository. Once you do that, you will need to push to your branch to cause tasks to start.
Flags: needinfo?(dustin)
Assignee: nobody → hritvi2801
I have enabled the taskcluster-github app im my repository and have pushed the .taskcluster.yml file in a new branch named taskcluser.yml-upload https://github.com/hritvi/taskcluster-login/blob/taskcluster.yml-upload/.taskcluster.yml . Now i am facing problem to start the task.
It already started : https://github.com/hritvi/taskcluster-login/commits/taskcluster.yml-upload has a yellow dot next to it. Clicking that dot will take you to the task. Github doesn't make it easy to find those dots / X / checkmarks -- you have to look in the "Commits" page for the branch you pushed to.
Thanks! The task has been successfully completed. Here's the link for details https://tools.taskcluster.net/groups/bsrpzWt2QYuv9iyxAIUf9A/tasks/bsrpzWt2QYuv9iyxAIUf9A/details So can i make a PR now on the main repository or should i first make a PR in my master branch and then in the main repository. I am sorry if i sound stupid.
Indeed, that looks good! You can make a PR straight from your taskcluster.yml-upload branch.
Finished in https://github.com/taskcluster/taskcluster-login/pull/82, and I followed up by deleting .travis.yml. Yay! Thanks!
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Thanks Dustin for your guidance :) Can I now challenge myself with bug 1441977?
Component: Platform and Services → Services
You need to log in before you can comment on or make changes to this bug.