1441984 - Hide OpeninPrivateBrowsing option in AS if PrivateBrowsingUtils.enabled is false

Status: RESOLVED FIXED

(Firefox :: New Tab Page, enhancement, P1)

Description

[Kate Hudson :k88hudson]

This is needed in order for our context menus to hide the open in private browsing option, and maybe useful for snippets anyway.

See Bug 1432355 for more details.

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4011

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/1623117fcb87682ffd4615be6a66f9c35c09becd
Bug 1441984 - Only show OpenInPrivateBrowsing option if private browsing enabled

https://github.com/mozilla/activity-stream/commit/f30bea2abda255e3c21c81b3c482a437491521f5
Merge pull request #4011 from k88hudson/bug1441984

Bug 1441984 - Only show OpenInPrivateBrowsing option if private browsing enabled

Comment 3

[Ed Lee :Mardak]

This bug depends on bug 1432355 to expose `PrivateBrowsingUtils.enabled` otherwise test added from bug 1410818 fails:

TEST-UNEXPECTED-FAIL | browser/extensions/activity-stream/test/functional/mochitest/browser_topsites_contextMenu_options.js | Name option is correct - "Dismiss" == "Open in a New Private Window" -

Comment 4

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/723f97b68476