Closed Bug 1441989 Opened 2 years ago Closed 9 months ago
Remove dead code from Content
47 bytes, text/x-phabricator-request
|Details | Review|
Remote newtab was using ContentVerifier.cpp since it was loading a remote resource, and that project has long been dead. The removal of the code has started in bug 1355166 for the files in browser/components/newtab, but there is leftover content verifying stuff that we no longer need. To quote Franziskus on bug 1355166: The only two services (I know of) using content signatures right now are blocklist updates and normandy. They both use the CS service directly. So I think ContentVerifier.cpp can go completely. To make that work there are changes to nsHTTPChannel necessary. However, before doing that it might be advisable to check whether this is used anywhere else. I don't think it is and a quick check doesn't reveal any callers of LoadInfo::SetVerifySignedContent (and without it content signature verification is not invoked from nsHTTPChannel). The LoadInfo bits can be removed as well then as it can't really be used anymore. This is touching a couple different parts but I think it's all dead code right now and should probably be removed.
Status: NEW → ASSIGNED
Priority: -- → P2
9 months ago
Assignee: adam.kasztenny → dkeeler
Priority: P2 → P1
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/8292a59d1957 remove ContentVerifier r=baku,mayhemer
You need to log in before you can comment on or make changes to this bug.