Closed Bug 1441990 Opened 2 years ago Closed 2 years ago

Allow tests to opt-out of test-verify

Categories

(Testing :: General, enhancement, P2)

Version 3
enhancement

Tracking

(firefox60 fixed)

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: gbrown, Assigned: gbrown)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

I'm just thinking of a manifest annotation:

  skip-if = verify
Why? I've seen a few examples that seemed reasonable. Here's one:

https://bugzilla.mozilla.org/show_bug.cgi?id=1415316#c1
Priority: -- → P2
Blocks: test-verify
I don't have a strategy for supporting this feature in non-mozinfo based manifests (like reftests, uggh), but for .ini manifests, this super-simple change works fine, allowing mochitests, xpcshell, etc manifests to opt-out of test-verify with:

skip-if = verify

https://treeherder.mozilla.org/#/jobs?repo=try&revision=efb0bbe5bd9749fa6cb8731b6bbb88aa75aad8fd
Attachment #8954986 - Flags: review?(jmaher)
Comment on attachment 8954986 [details] [diff] [review]
add 'verify' to mozinfo used for test-verify

Review of attachment 8954986 [details] [diff] [review]:
-----------------------------------------------------------------

wow, this is simple.  now to start annotating... ;)
Attachment #8954986 - Flags: review?(jmaher) → review+
Pushed by gbrown@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bf7e75d489bc
Support 'skip-if = verify' in mozinfo manifests; r=jmaher
https://hg.mozilla.org/mozilla-central/rev/bf7e75d489bc
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
See Also: → 1443177
Regressions: 1569982
You need to log in before you can comment on or make changes to this bug.