Closed Bug 1442028 Opened 2 years ago Closed 2 years ago

Move webdriver actions into its own module

Categories

(Testing :: geckodriver, enhancement)

Version 3
enhancement
Not set

Tracking

(firefox60 fixed)

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

Attachments

(1 file)

I quickly tried to rebase the patch on bug 1396821 today and noticed again a couple of conflicts. To minimize the work in the future lets already move the actions code from commands.rs into its own module. That way I don't have to rebase it again and again.
Attachment #8954940 - Flags: review?(ato)
Comment on attachment 8954940 [details]
Bug 1442028 - Move webdriver actions into its own module.

https://reviewboard.mozilla.org/r/224112/#review230368

::: testing/mozbase/mozcrash/mozcrash/mozcrash.py:98
(Diff revision 1)
>      if not crash_info.has_dumps:
>          return False
>  
>      crash_count = 0
>      for info in crash_info:
> +        print(info)

Debug leftover?

::: testing/mozbase/mozcrash/mozcrash/mozcrash.py:320
(Diff revision 1)
>                  os.makedirs(self.dump_save_path)
>              except OSError:
>                  pass
>  
>          shutil.move(path, self.dump_save_path)
> -        self.logger.info("Saved minidump as %s" %
> +        self.logger.info(u"Saved minidump as %s" %

Probably not necessary to include in this patch.
Attachment #8954940 - Flags: review?(ato) → review+
Comment on attachment 8954940 [details]
Bug 1442028 - Move webdriver actions into its own module.

https://reviewboard.mozilla.org/r/224112/#review230368

> Debug leftover?

Sorry, yes it is. I will remove both.
Attachment #8954940 - Flags: review?(james)
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/413a684727a2
Move webdriver actions into its own module. r=ato
https://hg.mozilla.org/mozilla-central/rev/413a684727a2
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.