Closed Bug 1442029 Opened 3 years ago Closed 3 years ago

Move XBL accessibility role="xul:colorpicker" and role="xul:colorpickertile" into XULMap.h

Categories

(Toolkit :: XUL Widgets, enhancement)

Product:
Toolkit
Component:
XUL Widgets
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla60
Tracking Flags:
Tracking Status
firefox60 --- fixed

People

(Reporter: timdream, Assigned: timdream)

References

Details

Attachments

(1 file)

Bug 1442029 - Move XBL accessibility role="xul:colorpicker" and role="xul:colorpickertile" into XULMap.h
59 bytes, text/x-review-board-request
surkov
: review+
enndeakin
: review+
Details 
Given that bug 1416363 is still pending let's get rid of the role attribute first.
Attachment #8954954 - Flags: review?(surkov.alexander)
Comment on attachment 8954954 [details]
Bug 1442029 - Move XBL accessibility role="xul:colorpicker" and role="xul:colorpickertile" into XULMap.h

https://reviewboard.mozilla.org/r/224146/#review230746

::: accessible/base/XULMap.h:79
(Diff revision 3)
>      }
>  
> +    if (aContent->IsElement() &&
> +        aContent->AsElement()->ClassList()->Contains(NS_LITERAL_STRING("colorpickertile"))) {
> +      return new XULColorPickerTileAccessible(aContent, aContext->Document());
> +    }

if (!aContent->IsElement() {
  return nsnull;
}
would be nicer.

Could you please file a follow up bug to change XULMAP functions to take Element* instead nsIContent* so we won't have to check IsElement() everytime?
Attachment #8954954 - Flags: review?(surkov.alexander) → review+
Comment on attachment 8954954 [details]
Bug 1442029 - Move XBL accessibility role="xul:colorpicker" and role="xul:colorpickertile" into XULMap.h

Neil, probably should take a look at XBL part
Attachment #8954954 - Flags: review?(enndeakin)
Attachment #8954954 - Flags: review?(enndeakin)
Comment on attachment 8954954 [details]
Bug 1442029 - Move XBL accessibility role="xul:colorpicker" and role="xul:colorpickertile" into XULMap.h

https://reviewboard.mozilla.org/r/224146/#review230972
Attachment #8954954 - Flags: review?(enndeakin) → review+
Pushed by timdream@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/194cb5ea7ed6
Move XBL accessibility role="xul:colorpicker" and role="xul:colorpickertile" into XULMap.h r=enndeakin+6102,surkov
https://hg.mozilla.org/mozilla-central/rev/194cb5ea7ed6
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox60: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.