1442029 - Move XBL accessibility role="xul:colorpicker" and role="xul:colorpickertile" into XULMap.h

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, enhancement)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Given that bug 1416363 is still pending let's get rid of the role attribute first.

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: Bug 1442029 - Move XBL accessibility role="xul:colorpicker" and role="xul:colorpickertile" into XULMap.h

- Removes the colorpickertile binding as it's no longer useful.
- Removes nsAccessibilityService::CreateAccessibleByType() as it has nothing to do anymore.

Review commit: https://reviewboard.mozilla.org/r/224146/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/224146/

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8954954 [details]
Bug 1442029 - Move XBL accessibility role="xul:colorpicker" and role="xul:colorpickertile" into XULMap.h

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/224146/diff/1-2/

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8954954 [details]
Bug 1442029 - Move XBL accessibility role="xul:colorpicker" and role="xul:colorpickertile" into XULMap.h

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/224146/diff/2-3/

Comment 4

[alexander :surkov (:asurkov)]

Comment on attachment 8954954 [details]
Bug 1442029 - Move XBL accessibility role="xul:colorpicker" and role="xul:colorpickertile" into XULMap.h

https://reviewboard.mozilla.org/r/224146/#review230746

::: accessible/base/XULMap.h:79
(Diff revision 3)
>      }
>  
> +    if (aContent->IsElement() &&
> +        aContent->AsElement()->ClassList()->Contains(NS_LITERAL_STRING("colorpickertile"))) {
> +      return new XULColorPickerTileAccessible(aContent, aContext->Document());
> +    }

if (!aContent->IsElement() {
  return nsnull;
}
would be nicer.

Could you please file a follow up bug to change XULMAP functions to take Element* instead nsIContent* so we won't have to check IsElement() everytime?

Comment 5

[alexander :surkov (:asurkov)]

Comment on attachment 8954954 [details]
Bug 1442029 - Move XBL accessibility role="xul:colorpicker" and role="xul:colorpickertile" into XULMap.h

Neil, probably should take a look at XBL part

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8954954 [details]
Bug 1442029 - Move XBL accessibility role="xul:colorpicker" and role="xul:colorpickertile" into XULMap.h

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/224146/diff/3-4/

Comment 7

[Neil Deakin]

Comment on attachment 8954954 [details]
Bug 1442029 - Move XBL accessibility role="xul:colorpicker" and role="xul:colorpickertile" into XULMap.h

https://reviewboard.mozilla.org/r/224146/#review230972

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/194cb5ea7ed6
Move XBL accessibility role="xul:colorpicker" and role="xul:colorpickertile" into XULMap.h r=enndeakin+6102,surkov

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/194cb5ea7ed6