Move XBL accessibility role="xul:colorpicker" and role="xul:colorpickertile" into XULMap.h

RESOLVED FIXED in Firefox 60

Status

()

RESOLVED FIXED
a year ago
a year ago

People

(Reporter: timdream, Assigned: timdream)

Tracking

unspecified
mozilla60
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox60 fixed)

Details

Attachments

(1 attachment)

Given that bug 1416363 is still pending let's get rid of the role attribute first.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 4

a year ago
mozreview-review
Comment on attachment 8954954 [details]
Bug 1442029 - Move XBL accessibility role="xul:colorpicker" and role="xul:colorpickertile" into XULMap.h

https://reviewboard.mozilla.org/r/224146/#review230746

::: accessible/base/XULMap.h:79
(Diff revision 3)
>      }
>  
> +    if (aContent->IsElement() &&
> +        aContent->AsElement()->ClassList()->Contains(NS_LITERAL_STRING("colorpickertile"))) {
> +      return new XULColorPickerTileAccessible(aContent, aContext->Document());
> +    }

if (!aContent->IsElement() {
  return nsnull;
}
would be nicer.

Could you please file a follow up bug to change XULMAP functions to take Element* instead nsIContent* so we won't have to check IsElement() everytime?
Attachment #8954954 - Flags: review?(surkov.alexander) → review+
Comment on attachment 8954954 [details]
Bug 1442029 - Move XBL accessibility role="xul:colorpicker" and role="xul:colorpickertile" into XULMap.h

Neil, probably should take a look at XBL part
Attachment #8954954 - Flags: review?(enndeakin)
Comment hidden (mozreview-request)

Comment 7

a year ago
mozreview-review
Comment on attachment 8954954 [details]
Bug 1442029 - Move XBL accessibility role="xul:colorpicker" and role="xul:colorpickertile" into XULMap.h

https://reviewboard.mozilla.org/r/224146/#review230972
Attachment #8954954 - Flags: review?(enndeakin) → review+

Comment 8

a year ago
Pushed by timdream@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/194cb5ea7ed6
Move XBL accessibility role="xul:colorpicker" and role="xul:colorpickertile" into XULMap.h r=enndeakin+6102,surkov
https://hg.mozilla.org/mozilla-central/rev/194cb5ea7ed6
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox60: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.