1442137 - Remove some unused categories from the script namespace manager

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P2)

Description

[Boris Zbarsky [:bzbarsky]]

"JavaScript-global-constructor" and "JavaScript-global-privileged-property" are completely unused.

"JavaScript-global-property" is used for InstallTrigger, looks like, and some sidebar bits in SeaMonkey which are probably no longer relevant due to webidl.  Also in two tests.  The InstallTrigger use is not completely trivial, so going to leave it for now.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: part 1. Remove support for the JavaScript-global-constructor category in the script namespace manager

MozReview-Commit-ID: 3tcvwufvXS3

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: part 2. Remove the now-unused eTypeExternalConstructor global name struct type

MozReview-Commit-ID: qb3mHnC5Ql

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: part 3. Remove code that only ran when nsDOMConstructor::IsConstructable() returned true, since it always returns false now

MozReview-Commit-ID: 6bTgNSRzxuS

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: part 4. Remove the JavaScript-global-privileged-property category from the script namespace manager

MozReview-Commit-ID: LRljHWSKyCx

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: part 5. Remove the unused NS_DEFINE_CHROME_XBL_CLASSINFO_DATA macro and then-unused mChromeOnly flag in nsDOMClassInfoData

MozReview-Commit-ID: 9P44FU8ISSw

Comment 6

[Boris Zbarsky [:bzbarsky]]

Attachment: part 6. Remove the now-always-false mChromeOnly and mAllowXBL flags in nsGlobalNameStruct

MozReview-Commit-ID: GarrbE696Sq

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/96cef81dfa4a
part 1.  Remove support for the JavaScript-global-constructor category in the script namespace manager.  r=peterv
https://hg.mozilla.org/integration/mozilla-inbound/rev/5e99d35936ed
part 2.  Remove the now-unused eTypeExternalConstructor global name struct type.  r=peterv
https://hg.mozilla.org/integration/mozilla-inbound/rev/13f8db6de966
part 3.  Remove code that only ran when nsDOMConstructor::IsConstructable() returned true, since it always returns false now.  r=peterv
https://hg.mozilla.org/integration/mozilla-inbound/rev/314f420f6b9c
part 4.  Remove the JavaScript-global-privileged-property category from the script namespace manager
https://hg.mozilla.org/integration/mozilla-inbound/rev/9ca183ba8345
part 5.  Remove the unused NS_DEFINE_CHROME_XBL_CLASSINFO_DATA macro and then-unused mChromeOnly flag in nsDOMClassInfoData.  r=peterv
https://hg.mozilla.org/integration/mozilla-inbound/rev/03ec4b083bf3
part 6.  Remove the now-always-false mChromeOnly and mAllowXBL flags in nsGlobalNameStruct.  r=peterv

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/96cef81dfa4a
https://hg.mozilla.org/mozilla-central/rev/5e99d35936ed
https://hg.mozilla.org/mozilla-central/rev/13f8db6de966
https://hg.mozilla.org/mozilla-central/rev/314f420f6b9c
https://hg.mozilla.org/mozilla-central/rev/9ca183ba8345
https://hg.mozilla.org/mozilla-central/rev/03ec4b083bf3