Remove some unused categories from the script namespace manager

RESOLVED FIXED in Firefox 61

Status

()

enhancement
P2
normal
RESOLVED FIXED
a year ago
2 months ago

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Tracking

(Blocks 1 bug)

unspecified
mozilla61
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox61 fixed)

Details

Attachments

(6 attachments)

"JavaScript-global-constructor" and "JavaScript-global-privileged-property" are completely unused.

"JavaScript-global-property" is used for InstallTrigger, looks like, and some sidebar bits in SeaMonkey which are probably no longer relevant due to webidl.  Also in two tests.  The InstallTrigger use is not completely trivial, so going to leave it for now.
Attachment #8955064 - Flags: review?(peterv) → review+
Attachment #8955065 - Flags: review?(peterv) → review+
Attachment #8955066 - Flags: review?(peterv) → review+
Attachment #8955067 - Flags: review?(peterv) → review+
Attachment #8955068 - Flags: review?(peterv) → review+
Attachment #8955069 - Flags: review?(peterv) → review+
Depends on: 888600, 1442040
Priority: -- → P2

Comment 7

a year ago
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/96cef81dfa4a
part 1.  Remove support for the JavaScript-global-constructor category in the script namespace manager.  r=peterv
https://hg.mozilla.org/integration/mozilla-inbound/rev/5e99d35936ed
part 2.  Remove the now-unused eTypeExternalConstructor global name struct type.  r=peterv
https://hg.mozilla.org/integration/mozilla-inbound/rev/13f8db6de966
part 3.  Remove code that only ran when nsDOMConstructor::IsConstructable() returned true, since it always returns false now.  r=peterv
https://hg.mozilla.org/integration/mozilla-inbound/rev/314f420f6b9c
part 4.  Remove the JavaScript-global-privileged-property category from the script namespace manager
https://hg.mozilla.org/integration/mozilla-inbound/rev/9ca183ba8345
part 5.  Remove the unused NS_DEFINE_CHROME_XBL_CLASSINFO_DATA macro and then-unused mChromeOnly flag in nsDOMClassInfoData.  r=peterv
https://hg.mozilla.org/integration/mozilla-inbound/rev/03ec4b083bf3
part 6.  Remove the now-always-false mChromeOnly and mAllowXBL flags in nsGlobalNameStruct.  r=peterv
Component: DOM → DOM: Core & HTML
Product: Core → Core
You need to log in before you can comment on or make changes to this bug.