1442149 - nsinstall fails: dumping usage during compile.

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Edmund Wong (:ewong)]

current linux trunk bustage:

cp /builds/slave/c-cen-t-lnx/build/suite/locales/en-US/profile/bookmarks.inc /builds/slave/c-cen-t-lnx/build/suite/locales/en-US/profile/bookmarks.extra /builds/slave/c-cen-t-lnx/build/suite/locales/generic/profile/bookmarks.html.in profile/
/builds/slave/c-cen-t-lnx/build/objdir/_virtualenv/bin/python -m mozbuild.action.jar_maker   -d ../../dist/bin -t /builds/slave/c-cen-t-lnx/build -f symlink  --relativesrcdir=suite/locales -c /builds/slave/c-cen-t-lnx/build/suite/locales/en-US -DNDEBUG=1 -DTRIMMED=1 -DMOZ_APP_MAXVERSION=2.57a1 -DDLL_PREFIX=lib -DDLL_SUFFIX=.so -DBIN_SUFFIX= -DDIR_MACOS= -DDIR_RESOURCES= -DA11Y_LOG=1 -DACCESSIBILITY=1 -DATK_MAJOR_VERSION=2 -DATK_MINOR_VERSION=2 -DATK_REV_VERSION=0 -DBUILD_CTYPES=1 -DCROSS_COMPILE='' -DEARLY_BETA_OR_EARLIER=1 -DENABLE_INTL_API=1 -DENABLE_SYSTEM_EXTENSION_DIRS=1 -DENABLE_TESTS=1 -DEXPOSE_INTL_API=1 -DFIREFOX_VERSION=60.0a1 -DFORCE_PR_LOG=1 -DFUNCPROTO=15 -DGDK_VERSION_MAX_ALLOWED=GDK_VERSION_3_4 -DGLIB_VERSION_MAX_ALLOWED=GLIB_VERSION_2_32 -DGLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_26 -DGL_PROVIDER_GLX=1 -DGTEST_HAS_RTTI=0 -DHAVE_ALLOCA_H=1 -DHAVE_BYTESWAP_H=1 -DHAVE_CLOCK_MONOTONIC=1 -DHAVE_CPUID_H=1 -DHAVE_DIRENT_H=1 -DHAVE_DLADDR=1 -DHAVE_DLOPEN=1 -DHAVE_FONTCONFIG_FCFREETYPE_H=1 -DHAVE_FT_BITMAP_SIZE_Y_PPEM=1 -DHAVE_FT_GLYPHSLOT_EMBOLDEN=1 -DHAVE_FT_LOAD_SFNT_TABLE=1 -DHAVE_GETOPT_H=1 -DHAVE_GMTIME_R=1 -DHAVE_INTTYPES_H=1 -DHAVE_LCHOWN=1 -DHAVE_LINUX_IF_ADDR_H=1 -DHAVE_LINUX_PERF_EVENT_H=1 -DHAVE_LINUX_QUOTA_H=1 -DHAVE_LINUX_RTNETLINK_H=1 -DHAVE_LOCALECONV=1 -DHAVE_LOCALTIME_R=1 -DHAVE_LSTAT64=1 -DHAVE_MALLINFO=1 -DHAVE_MALLOC_H=1 -DHAVE_MALLOC_USABLE_SIZE=1 -DHAVE_MEMALIGN=1 -DHAVE_MEMMEM=1 -DHAVE_MOVEMAIL=1 -DHAVE_NETINET_IN_H=1 -DHAVE_NL_TYPES_H=1 -DHAVE_POSIX_FADVISE=1 -DHAVE_POSIX_FALLOCATE=1 -DHAVE_POSIX_MEMALIGN=1 -DHAVE_PTHREAD_H=1 -DHAVE_RES_NINIT=1 -DHAVE_SETPRIORITY=1 -DHAVE_STAT64=1 -DHAVE_STDINT_H=1 -DHAVE_STRERROR=1 -DHAVE_STRNDUP=1 -DHAVE_SYSCALL=1 -DHAVE_SYS_QUEUE_H=1 -DHAVE_SYS_QUOTA_H=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_THREAD_TLS_KEYWORD=1 -DHAVE_TRUNCATE64=1 -DHAVE_UNISTD_H=1 -DHAVE_VALLOC=1 -DHAVE_VA_COPY=1 -DHAVE_VISIBILITY_ATTRIBUTE=1 -DHAVE_VISIBILITY_HIDDEN_ATTRIBUTE=1 -DHAVE__UNWIND_BACKTRACE=1 -DHAVE___CXA_DEMANGLE=1 -DJS_BUILD_BINAST=1 -DJS_CODEGEN_X86=1 -DJS_DEFAULT_JITREPORT_GRANULARITY=3 -DJS_NUNBOX32=1 -DMALLOC_H='<malloc.h>' -DMALLOC_USABLE_SIZE_CONST_PTR='' -DMOZILLA_OFFICIAL=1 -DMOZILLA_UAVERSION='"60.0"' -DMOZILLA_VERSION='"60.0a1"' -DMOZILLA_VERSION_U=60.0a1 -DMOZ_ACCESSIBILITY_ATK=1 -DMOZ_ALLOW_LEGACY_EXTENSIONS=1 -DMOZ_APP_UA_NAME='""' -DMOZ_APP_UA_VERSION='"2.57a1"' -DMOZ_AV1=1 -DMOZ_BUILD_APP=../suite -DMOZ_BUNDLED_FONTS=1 -DMOZ_CONTENT_SANDBOX=1 -DMOZ_CRASHREPORTER=1 -DMOZ_DATA_REPORTING=1 -DMOZ_DISTRIBUTION_ID='"org.mozilla"' -DMOZ_DLL_SUFFIX='".so"' -DMOZ_ENABLE_DBUS=1 -DMOZ_ENABLE_GCONF=1 -DMOZ_ENABLE_SKIA=1 -DMOZ_ENABLE_SKIA_PDF=1 -DMOZ_ENABLE_SKIA_PDF_SFNTLY=1 -DMOZ_ENABLE_XREMOTE=1 -DMOZ_FEEDS=1 -DMOZ_FFMPEG=1 -DMOZ_FFVPX=1 -DMOZ_FFVPX_FLACONLY=1 -DMOZ_FMP4=1 -DMOZ_GECKO_PROFILER=1 -DMOZ_GLUE_IN_PROGRAM=1 -DMOZ_GMP_SANDBOX=1 -DMOZ_INSTRUMENT_EVENT_LOOP=1 -DMOZ_LDAP_XPCOM=1 -DMOZ_LOGGING=1 -DMOZ_MACBUNDLE_ID=org.mozilla.seamonkey -DMOZ_MEMORY=1 -DMOZ_OLD_STYLE=1 -DMOZ_PEERCONNECTION=1 -DMOZ_PLACES=1 -DMOZ_PROFILING=1 -DMOZ_PULSEAUDIO=1 -DMOZ_RAW=1 -DMOZ_REPLACE_MALLOC=1 -DMOZ_RUST_SIMD=1 -DMOZ_SAMPLE_TYPE_FLOAT32=1 -DMOZ_SANDBOX=1 -DMOZ_SCTP=1 -DMOZ_SEPARATE_MANIFEST_FOR_THEME_OVERRIDES=1 -DMOZ_SRTP=1 -DMOZ_STATIC_JS=1 -DMOZ_SUITE=1 -DMOZ_TREE_CAIRO=1 -DMOZ_TREE_PIXMAN=1 -DMOZ_UPDATER=1 -DMOZ_UPDATE_CHANNEL=default -DMOZ_USER_DIR='".mozilla"' -DMOZ_VORBIS=1 -DMOZ_VPX_NO_MEM_REPORTING=1 -DMOZ_VTUNE=1 -DMOZ_WEBM_ENCODER=1 -DMOZ_WEBRTC=1 -DMOZ_WEBRTC_ASSERT_ALWAYS=1 -DMOZ_WEBRTC_SIGNALING=1 -DMOZ_WEBSPEECH=1 -DMOZ_WEBSPEECH_TEST_BACKEND=1 -DMOZ_WIDGET_GTK=3 -DMOZ_X11=1 -DMOZ_XUL=1 -DNIGHTLY_BUILD=1 -DNO_NSPR_10_SUPPORT=1 -DNS_PRINTING=1 -DNS_PRINT_PREVIEW=1 -DSTATIC_JS_API=1 -DSTDC_HEADERS=1 -DTARGET_XPCOM_ABI='"x86-gcc3"' -DUSE_SKIA=1 -DUSE_SKIA_GPU=1 -DU_STATIC_IMPLEMENTATION=1 -DU_USING_ICU_NAMESPACE=0 -DVA_COPY=va_copy -DVPX_X86_ASM=1 -DXP_LINUX=1 -DXP_UNIX=1 -D_REENTRANT=1 -DAB_CD=en-US -DAB_CD=en-US -DMOZ_LANGPACK_EID=[e-mail] -DMOZ_APP_ID='{92650c4d-4b8e-4d2a-b7eb-24ecf4f6b63a}' -DMOZ_APP_VERSION=2.57a1 -DMOZ_APP_MAXVERSION=2.57a1 -DLOCALE_SRCDIR=/builds/slave/c-cen-t-lnx/build/suite/locales/en-US -DPKG_BASENAME='seamonkey-2.57a1.en-US.linux-i686' -DPKG_INST_BASENAME='seamonkey-2.57a1.en-US.linux-i686.installer'  /builds/slave/c-cen-t-lnx/build/suite/locales/jar.mn
sed \
  -n 's/.*<RDF:Description about="\(.*\)">.*/        <RDF:li resource="\1"\/>/p' \
  profile/panels.extra > profile/panels-urn.inc
/builds/slave/c-cen-t-lnx/build/objdir/_virtualenv/bin/python -m mozbuild.action.preprocessor  profile/panels.rdf.in -o ../../dist/bin/defaults/profile/panels.rdf
/builds/slave/c-cen-t-lnx/build/objdir/_virtualenv/bin/python -m mozbuild.action.preprocessor  -DAB_CD=en-US profile/bookmarks.html.in -o ../../dist/bin/defaults/profile/bookmarks.html
processing /builds/slave/c-cen-t-lnx/build/suite/locales/jar.mn
../../config/nsinstall -t -m 644  ../../dist/bin/defaults/profile/chrome
usage: ../../config/nsinstall [-C cwd] [-L linkprefix] [-m mode] [-o owner] [-g group]
                              [-DdltR] file [file ...] directory
make[4]: *** [libs] Error 2
make[4]: Leaving directory `/builds/slave/c-cen-t-lnx/build/objdir/suite/locales'
make[3]: *** [suite/locales/libs] Error 2
make[3]: Leaving directory `/builds/slave/c-cen-t-lnx/build/objdir'
make[2]: *** [libs] Error 2
make[2]: Leaving directory `/builds/slave/c-cen-t-lnx/build/objdir'
make[1]: *** [default] Error 2
make[1]: Leaving directory `/builds/slave/c-cen-t-lnx/build/objdir'
make: *** [build] Error 2

Comment 1

[Edmund Wong (:ewong)]

Most likely a fallout from bug 1439742.

Comment 2

[Edmund Wong (:ewong)]

Attachment: proposed patch

adding MERGE_FILES and EN_US_OR_L10N_FILE(S) back into the
Makefile.in will workaround this; but we'll still need to update
our makefiles to reflect the changes that m-c is doing with
Bug 1439742.

Comment 3

[Frank-Rainer Grahl (:frg)]

Comment on attachment 8955049 [details] [diff] [review]
proposed patch

Can't test right now but looks good. 

NIT: Please put a reference to the bug which removed it from config.mk in the comment.

Comment 4

[Jorg K (CEST = GMT+2)]

Comment on attachment 8955049 [details] [diff] [review]
proposed patch

Review of attachment 8955049 [details] [diff] [review]:
-----------------------------------------------------------------

Could that be related to bug 1441812? Something with search is failing there.

::: suite/locales/Makefile.in
@@ +113,5 @@
>  PANELS_XTRA_FILE = $(call MERGE_FILE,profile/panels.extra)
>  
> +MERGE_FILES = $(foreach f,$(1),$(call MERGE_FILE,$(f)))
> +
> +# These marcros are similar to MERGE_FILE, but no merging, and en-US first.

Typo here.

Comment 5

[Edmund Wong (:ewong)]

Attachment: proposed patch (v2) fixed comment nit.

Thanks jorgk for the typo catch.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/dada7b1b4e03
Re-instate MERGE_FILES and EN_US_OR_L10N_FILE. r=frg

Comment 7

[Edmund Wong (:ewong)]

(In reply to Jorg K (GMT+1) from comment #4)
> Comment on attachment 8955049 [details] [diff] [review]
> proposed patch
> 
> Review of attachment 8955049 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Could that be related to bug 1441812? Something with search is failing there.
> 

Not entirely sure.  I'll need to have a look at what's going on with how it's
doing the search.

Comment 8

[Frank-Rainer Grahl (:frg)]

Attachment: 1442149-followup-searchplugins.patch

Followup patch from Bill. Just needed to be moved higher and unused EN_US_OR_L10N_FILES was be removed. tested. r+ from me and thanks.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/52cdb91d9768
Move MERGE_FILES and EN_US_OR_L10N_FILE to immediately after the import of config.mk. r=frg

Comment 10

[Jorg K (CEST = GMT+2)]

Thanks from me as well! Already landed for TB in bug 1441812 :-)