1442153 - browser_inspector_expand-collapse.js fails when converted to async/await instead of Task

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P3)

Description

[Alexandre Poirot [:ochameau]]

$ ./mach mochitest devtools/client/inspector/test/browser_inspector_expand-collapse.js

fails with this error:

TEST-UNEXPECTED-FAIL | devtools/client/inspector/test/browser_inspector_expand-collapse.js | node has been successfully expanded

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1442153 - Convert browser_inspector_expand-collapse.js to async/await.

Review commit: https://reviewboard.mozilla.org/r/224218/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/224218/

Comment 2

[Alexandre Poirot [:ochameau]]

Hum, that's fascinating, the error from comment 0 happens when you are based on top of my WIP patch for bug 1440321 (converting the whole client folder to async/await)

On top of m-c tip, you get this error instead:
TEST-UNEXPECTED-FAIL | devtools/client/inspector/test/browser_inspector_expand-collapse.js | Uncaught exception - Protocol error (unknownError): '' is not a valid selector

Note that is may be related to bug 1441531 as this test also uses waitForMultipleChildrenUpdates.

Comment 3

[Yulia Startsev [:yulia]]

This is related to the changes in bug 1441531. We will need to wait for those changes to land before we can merge the fix for this. I'm running try now to make sure nothing else broke.

Comment 4

[Yulia Startsev [:yulia]]

Attachment: Bug 1442153 - Convert browser_inspector_expand-collaps.js to async await and getNodeFrontForSelector in test/head.

Review commit: https://reviewboard.mozilla.org/r/228440/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/228440/

Comment 5

[Yulia Startsev [:yulia]]

Generators have some funny behavior with async/await it looks like... It was returning a generator object rather than the return value. Since no other tests were relying on the function in question i updated it to be async/await as well

Comment 6

[Alexandre Poirot [:ochameau]]

Comment on attachment 8959623 [details]
Bug 1442153 - Convert browser_inspector_expand-collaps.js to async await and getNodeFrontForSelector in test/head.

https://reviewboard.mozilla.org/r/228440/#review234564

Thanks Yulia, do not hesitate to squash my change into yours.

Comment 7

[Yulia Startsev [:yulia]]

Attachment: Bug 1442153 - Convert browser_inspector_expand-collapse.js to async/await.

Review commit: https://reviewboard.mozilla.org/r/231220/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/231220/

Comment 8

[Alexandre Poirot [:ochameau]]

Comment on attachment 8962358 [details]
Bug 1442153 - Convert browser_inspector_expand-collapse.js to async/await.

https://reviewboard.mozilla.org/r/231220/#review236614

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0a61a8fd3866
Convert browser_inspector_expand-collapse.js to async/await. r=ochameau

Comment 10

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/0a61a8fd3866