Closed Bug 1442153 Opened 2 years ago Closed 2 years ago

browser_inspector_expand-collapse.js fails when converted to async/await instead of Task

Categories

(DevTools :: Inspector, defect, P3)

defect

Tracking

(firefox61 fixed)

RESOLVED FIXED
Firefox 61
Tracking Status
firefox61 --- fixed

People

(Reporter: ochameau, Assigned: yulia)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 2 obsolete files)

$ ./mach mochitest devtools/client/inspector/test/browser_inspector_expand-collapse.js

fails with this error:

TEST-UNEXPECTED-FAIL | devtools/client/inspector/test/browser_inspector_expand-collapse.js | node has been successfully expanded
Hum, that's fascinating, the error from comment 0 happens when you are based on top of my WIP patch for bug 1440321 (converting the whole client folder to async/await)

On top of m-c tip, you get this error instead:
TEST-UNEXPECTED-FAIL | devtools/client/inspector/test/browser_inspector_expand-collapse.js | Uncaught exception - Protocol error (unknownError): '' is not a valid selector

Note that is may be related to bug 1441531 as this test also uses waitForMultipleChildrenUpdates.
Assignee: nobody → ystartsev
This is related to the changes in bug 1441531. We will need to wait for those changes to land before we can merge the fix for this. I'm running try now to make sure nothing else broke.
Depends on: 1441531
No longer blocks: 1440321
Attachment #8955041 - Attachment is obsolete: true
Generators have some funny behavior with async/await it looks like... It was returning a generator object rather than the return value. Since no other tests were relying on the function in question i updated it to be async/await as well
Comment on attachment 8959623 [details]
Bug 1442153 - Convert browser_inspector_expand-collaps.js to async await and getNodeFrontForSelector in test/head.

https://reviewboard.mozilla.org/r/228440/#review234564

Thanks Yulia, do not hesitate to squash my change into yours.
Attachment #8959623 - Flags: review?(poirot.alex) → review+
Priority: -- → P3
Attachment #8959623 - Attachment is obsolete: true
Comment on attachment 8962358 [details]
Bug 1442153 - Convert browser_inspector_expand-collapse.js to async/await.

https://reviewboard.mozilla.org/r/231220/#review236614
Attachment #8962358 - Flags: review?(poirot.alex) → review+
Pushed by ystartsev@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0a61a8fd3866
Convert browser_inspector_expand-collapse.js to async/await. r=ochameau
https://hg.mozilla.org/mozilla-central/rev/0a61a8fd3866
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.