1442160 - browser_storage_dynamic_updates_localStorage.js and browser_storage_dynamic_updates_sessionstorage.js are using unnecessary generators

Status: RESOLVED FIXED

(DevTools :: Storage Inspector, enhancement)

Description

[Alexandre Poirot [:ochameau]]

These two files are using generators to call `clear` method, but this method never wait for any promise or async operation. So we could use plain functions instead.
That would help the Task.jsm refactoring (bug 1440321)
https://searchfox.org/mozilla-central/source/devtools/client/storage/test/browser_storage_dynamic_updates_localStorage.js#53-58
https://searchfox.org/mozilla-central/source/devtools/client/storage/test/browser_storage_dynamic_updates_sessionStorage.js#67-72
  // Clearing items. Bug 1233497 makes it so that we can no longer yield
  // CPOWs from Tasks. We work around this by calling clear via a ContentTask
  // instead.
  yield ContentTask.spawn(gBrowser.selectedBrowser, null, function* () {
    return Task.spawn(content.wrappedJSObject.clear);
  });

https://searchfox.org/mozilla-central/source/devtools/client/storage/test/storage-updates.html#35-46
/**
 * We keep this method here even though these items are automatically cleared
 * after the test is complete. this is so that the store-objects-cleared event
 * can be tested.
 */
window.clear = function*() {
  localStorage.clear();
  dump("removed localStorage from " + document.location + "\n");

  sessionStorage.clear();
  dump("removed sessionStorage from " + document.location + "\n");
};

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1442160 - Remove unnecessary usages of generators in storage test.

Review commit: https://reviewboard.mozilla.org/r/224226/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/224226/

Comment 2

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8955048 [details]
Bug 1442160 - Remove unnecessary usages of generators in storage test.

https://reviewboard.mozilla.org/r/224226/#review231270

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d82a087fd56d
Remove unnecessary usages of generators in storage test. r=miker

Comment 4

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/d82a087fd56d