1442196 - HTML form element not exposed as a form landmark when it has an accessible name

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[steve faulkner]

It is expected that when a form element has an explicitname=true iA2 object property, the form element will have an accompanying attribute object xml-roles:form, so that AT can recognise it as a form landmark.


refer to
https://w3c.github.io/html-aam/#el-form
https://w3c.github.io/core-aam/#mapping_role_table

related JAWS issue: https://github.com/FreedomScientific/VFO-standards-support/issues/52

Comment 1

[steve faulkner]

test case: http://www.scottohara.me/testing/form/

Comment 2

[Marco Zehe (:MarcoZ)]

Trivial fix, taking.

Comment 3

[Marco Zehe (:MarcoZ)]

Attachment: Bug 1442196 - Expose an XML role of 'form' on a form element if it has an accessible name,

Review commit: https://reviewboard.mozilla.org/r/224974/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/224974/

Comment 4

[alexander :surkov (:asurkov)]

Comment on attachment 8956031 [details]
Bug 1442196 - Expose an XML role of 'form' on a form element if it has an accessible name,

https://reviewboard.mozilla.org/r/224974/#review230966

::: accessible/generic/HyperTextAccessible.cpp:1162
(Diff revision 1)
> +  // Only return xml-roles "form" if the form has an accessible name.
> +  if (mContent->IsHTMLElement(nsGkAtoms::form)) {
> +    nsAutoString name;
> +    const_cast<HyperTextAccessible*>(this)->Name(name);
> +    return name.IsEmpty() ? nullptr : nsGkAtoms::form;
> +  }

alternatively, you could change LandmarkRole() to LandmarkRole(bool hasExplicitName) and pass there true if 'explicit-name' is set, to avoid double computation of Name().

Comment 5

[Marco Zehe (:MarcoZ)]

After discussion on IRC, we agreed to push that parameter reorg to a different bug and land the patch above as-is.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/916d91f23f89
Expose an XML role of 'form' on a form element if it has an accessible name, r=surkov

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/916d91f23f89