1442248 - Crash in java.lang.NullPointerException: Attempt to invoke interface method 'java.lang.Object java.util.Map.get(java.lang.Object)' on a null object reference at org.mozilla.gecko.sync.GlobalSession.getSyncStageByName(GlobalSession.java)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Android Sync, defect, P1)

Description

[Marcia Knous [:marcia]]

This bug was filed from the Socorro interface and is
report bp-1772dc29-7ce6-4185-991a-a73430180301.
=============================================================

Seen while looking at nightly crash data. While this is present in earlier versions, there are now more crashes in Nightly than 58.0.2: http://bit.ly/2t8V3gh. No useful comments available.


Top 10 frames of crashing thread:

0 libxul.so GeckoAppShellSupport::ReportJavaCrash widget/android/nsAppShell.cpp:276
1 libxul.so mozilla::jni::NativeStub<mozilla::java::GeckoAppShell::ReportJavaCrash_t, GeckoAppShellSupport, mozilla::jni::Args<const mozilla::jni::Ref<mozilla::jni::TypedObject<_jthrowable*>, _jthrowable*>&, const mozilla::jni::StringParam&> >::Wrap<&GeckoAppShellSupport::ReportJavaCrash> widget/android/jni/Natives.h:778
2 base.odex base.odex@0x8c1e9d 
3 dalvik-LinearAlloc_7933_7933 (deleted) dalvik-LinearAlloc_7933_7933 @0x468a 
4 dalvik-main space_1898_1898 (deleted) dalvik-main space_1898_1898 @0x87fe 
5 dalvik-main space_1898_1898 (deleted) dalvik-main space_1898_1898 @0x4efa9e 
6 dalvik-main space_1898_1898 (deleted) dalvik-main space_1898_1898 @0x5c1ffe 
7 libart.so libart.so@0xa9241 
8 dalvik-main space_1898_1898 (deleted) dalvik-main space_1898_1898 @0x4efa9e 
9 dalvik-main space_1898_1898 (deleted) dalvik-main space_1898_1898 @0x5c1ffe 

=============================================================

Comment 1

[Marcia Knous [:marcia]]

The nightly 60 spike started in the 20180227100125 build. Prior to that, there had been single crashes in a few earlier builds.

Comment 2

[Mike Taylor [:miketaylr]]

This is wontfix for 58, and I'm gonna fixoptional for 59 given volume.

Comment 3

[:Grisha Kruglov]

Recent spikes likely related to Bug 1408710.

Comment 4

[Julien Cristau [:jcristau] (back April 22)]

crash rate increases in beta60.

Comment 5

[Richard Newman [:rnewman]]

This should be fixed by Bug 1445462.

Comment 6

[Richard Newman [:rnewman]]

> This should be fixed by Bug 1445462.

(But clearly it's not.)

Comment 7

[Phabricator Automation]

Attachment: Bug 1442248 - Don't attempt to advance to the next sync stage if we've aborted. r?eoger

Comment 8

[Phabricator Automation]

Comment on attachment 8965426 [details]
Bug 1442248 - Don't attempt to advance to the next sync stage if we've aborted. r?eoger

Edouard Oger [:eoger] has approved the revision.

https://phabricator.services.mozilla.com/D857

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6edfdf55da58
Don't attempt to advance to the next sync stage if we've aborted. r=eoger

Comment 10

[Dorel Luca [:dluca]]

Backed out changeset 6edfdf55da58 (bug 1442248) for Android build bustages. CLOSED TREE

Log of the failure:
https://treeherder.mozilla.org/logviewer.html#?job_id=172162334&repo=mozilla-inbound&lineNumber=23587

Backout:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c5788ecf518b9269c504057bd99ed4a3e354f45a

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=6edfdf55da5862b64f03dd8ce159c265b4b40ef0

Comment 11

[Edouard Oger [:eoger]]

rnewman has pushed a new revision, please check-in again, thanks :)

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0b72b7ce7b53
Don't attempt to advance to the next sync stage if we've aborted. r=eoger

Comment 13

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/0b72b7ce7b53

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Please request Beta approval on this when you get a chance. Though the frequency seems to have dropped way off after b5.

Comment 15

[Edouard Oger [:eoger]]

Comment on attachment 8965426 [details]
Bug 1442248 - Don't attempt to advance to the next sync stage if we've aborted. r?eoger

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1408710 (but has been seen before)
[User impact if declined]: A small amount of sync users will see their Firefox instance crash on Android.
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: no (hard to reproduce)
[Needs manual test from QE? If yes, steps to reproduce]: 
[List of other uplifts needed for the feature/fix]: -
[Is the change risky?]: No
[Why is the change risky/not risky?]: We stop the state machine safely instead of crashing with a NPE.
[String changes made/needed]: -

Comment 16

[Julien Cristau [:jcristau] (back April 22)]

Comment on attachment 8965426 [details]
Bug 1442248 - Don't attempt to advance to the next sync stage if we've aborted. r?eoger

paper over a crash in fennec, approved for beta60

Comment 17

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/9b49a4d34924