Remove GeckoLoader.setLastIntent

RESOLVED FIXED in Firefox 60

Status

enhancement
RESOLVED FIXED
a year ago
5 months ago

People

(Reporter: jchen, Assigned: jchen)

Tracking

unspecified
mozilla60
All
Android

Firefox Tracking Flags

(firefox60 fixed)

Details

Attachments

(7 attachments)

Replace setLastIntent with an extras bundle for GeckoThread
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 6

a year ago
mozreview-review
Comment on attachment 8955144 [details]
Bug 1442255 - 1. Replace setLastIntent with extras bundle;

https://reviewboard.mozilla.org/r/224302/#review230474
Attachment #8955144 - Flags: review?(esawin) → review+

Comment 7

a year ago
mozreview-review
Comment on attachment 8955145 [details]
Bug 1442255 - 2. Replace GeckoThread fields with extras bundle;

https://reviewboard.mozilla.org/r/224304/#review230480
Attachment #8955145 - Flags: review?(esawin) → review+

Comment 8

a year ago
mozreview-review
Comment on attachment 8955146 [details]
Bug 1442255 - 3. Use extras bundle to initialize Gecko in GeckoView;

https://reviewboard.mozilla.org/r/224306/#review230484
Attachment #8955146 - Flags: review?(esawin) → review+

Comment 9

a year ago
mozreview-review
Comment on attachment 8955147 [details]
Bug 1442255 - 4. Use extras bundle to initialize Gecko in Fennec;

https://reviewboard.mozilla.org/r/224308/#review230490

::: mobile/android/base/java/org/mozilla/gecko/GeckoApplication.java:105
(Diff revision 1)
>       */
>      public static String getSessionUUID() {
>          return sSessionUUID;
>      }
>  
> -    public static String addDefaultGeckoArgs(String args) {
> +    public static String[] getDefaultGeckoArgs() {

@Nullable

::: mobile/android/geckoview/src/main/java/org/mozilla/gecko/mozglue/SafeIntent.java:44
(Diff revision 1)
>              Log.w(LOGTAG, "Couldn't determine if intent had an extra.", e);
>              return false;
>          }
>      }
>  
> +    public Bundle getExtras() {

@Nullable
Attachment #8955147 - Flags: review?(esawin) → review+

Comment 10

a year ago
mozreview-review
Comment on attachment 8955148 [details]
Bug 1442255 - 5. Use extras bundle to initialize child processes;

https://reviewboard.mozilla.org/r/224310/#review230494
Attachment #8955148 - Flags: review?(esawin) → review+
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Assignee

Comment 18

a year ago
mozreview-review
Comment on attachment 8956328 [details]
Bug 1442255 - 6. Adjust process count for GeckoView;

https://reviewboard.mozilla.org/r/225192/#review231162
Attachment #8956328 - Flags: review+
Assignee

Comment 19

a year ago
mozreview-review
Comment on attachment 8956329 [details]
Bug 1442255 - 7. Switch the order of fd arguments;

https://reviewboard.mozilla.org/r/225194/#review231164
Attachment #8956329 - Flags: review+

Comment 20

a year ago
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d7a43e59a1b4
1. Replace setLastIntent with extras bundle; r=esawin
https://hg.mozilla.org/integration/autoland/rev/08f906f3a0c8
2. Replace GeckoThread fields with extras bundle; r=esawin
https://hg.mozilla.org/integration/autoland/rev/c3305648ad30
3. Use extras bundle to initialize Gecko in GeckoView; r=esawin
https://hg.mozilla.org/integration/autoland/rev/5d0f72867f53
4. Use extras bundle to initialize Gecko in Fennec; r=esawin
https://hg.mozilla.org/integration/autoland/rev/62d1c57c37b4
5. Use extras bundle to initialize child processes; r=esawin
https://hg.mozilla.org/integration/autoland/rev/6a794e14fceb
6. Adjust process count for GeckoView; r=jchen
https://hg.mozilla.org/integration/autoland/rev/208c4c42f641
7. Switch the order of fd arguments; r=jchen
Backed out 7 changesets (bug 1442255) for failing c1 tests on mochitest/test_browserElement_inproc_PurgeHistory.html

Backout link: https://hg.mozilla.org/integration/autoland/rev/b1dc3a24a077e384e3c439453cd800636e2cf173

Push where failures started: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=208c4c42f641e189ac930ef0831b38d502c7374c

Log link: https://treeherder.mozilla.org/logviewer.html#?job_id=166221463&repo=autoland&lineNumber=2141

[task 2018-03-06T14:17:33.000Z] 14:17:33     INFO -  153 INFO TEST-START | dom/browser-element/mochitest/test_browserElement_inproc_PurgeHistory.html
[task 2018-03-06T14:22:56.709Z] 14:22:56     INFO -  154 INFO TEST-UNEXPECTED-FAIL | dom/browser-element/mochitest/test_browserElement_inproc_PurgeHistory.html | Test timed out.
[task 2018-03-06T14:22:56.710Z] 14:22:56     INFO -  reportError@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:121:7
[task 2018-03-06T14:22:56.710Z] 14:22:56     INFO -  TestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:142:7
Flags: needinfo?(nchen)
Flags: needinfo?(nchen)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 29

a year ago
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/47c1e6667b85
1. Replace setLastIntent with extras bundle; r=esawin
https://hg.mozilla.org/integration/autoland/rev/ab953c63958b
2. Replace GeckoThread fields with extras bundle; r=esawin
https://hg.mozilla.org/integration/autoland/rev/10aa0b36b674
3. Use extras bundle to initialize Gecko in GeckoView; r=esawin
https://hg.mozilla.org/integration/autoland/rev/f5947781c990
4. Use extras bundle to initialize Gecko in Fennec; r=esawin
https://hg.mozilla.org/integration/autoland/rev/be83fd0b04b6
5. Use extras bundle to initialize child processes; r=esawin
https://hg.mozilla.org/integration/autoland/rev/ec84d9eb4351
6. Adjust process count for GeckoView; r=jchen
https://hg.mozilla.org/integration/autoland/rev/140e1bb89e8b
7. Switch the order of fd arguments; r=jchen

Updated

5 months ago
Product: Firefox for Android → GeckoView
Target Milestone: Firefox 60 → mozilla60
You need to log in before you can comment on or make changes to this bug.