1442294 - When video disabled (A/V situation) the red camera icon (URL bar) should be downgraded to the red microphone icon(URL bar)

Status: VERIFIED FIXED

(Core :: WebRTC: Audio/Video, defect, P2)

Description

[Adrian Florinescu [:aflorinescu]]

[Description:]
Based on:
https://bugzilla.mozilla.org/show_bug.cgi?id=1436033#c9
https://bugzilla.mozilla.org/show_bug.cgi?id=1436033#c14
https://drive.google.com/file/d/0B8kj4Mlm-HJecktURGQzanI0c1U/view
https://bugzilla.mozilla.org/show_bug.cgi?id=1333468

This only concerns the scenario in which the video gets disabled (not unplugged - which is handled in other bugs). 

[Steps:]
1. Start an A/V call (A/V have different sources - headset/webcam).
2. Disable(mute) the video feed - sound remains on.
3. Click on the blinking red camera in the URL bar.

[Actual Result:]

video feed - disabled
sound feed - enabled

video indicator (URL bar) - active (red blinking camera)
sound indicator (URL bar) - not displayed 

video indicator (permissions block) - disabled (grey icon)
sound indicator (permissions block) - active (red blinking microphone)



[Expected Result:]

video feed - disabled
sound feed - enabled

video indicator (URL bar) - not displayed 
sound indicator (URL bar) - active (red blinking microphone)

video indicator (permissions block) - disabled (grey icon)
sound indicator (permissions block) - active (red blinking microphone)

Comment 1

[Johann Hofmann [:johannh]]

Attachment: Bug 1442294 - Downgrade global streaming indicator when a higher priority device has been disabled.

Review commit: https://reviewboard.mozilla.org/r/226070/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/226070/

Comment 2

[Johann Hofmann [:johannh]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=20668e90464a585421fd854462208f2a592301f8

Comment 3

[Florian Quèze [:florian]]

Comment on attachment 8957131 [details]
Bug 1442294 - Downgrade global streaming indicator when a higher priority device has been disabled.

https://reviewboard.mozilla.org/r/226070/#review232042

The code change looks good. I'll r+ if you can convince me that we already have a test covering this case:
share audio+video, disable video, check sharing indicator, re-enable video, check sharing indicator
or if you add it :-)

Comment 4

[Johann Hofmann [:johannh]]

(In reply to Florian Quèze [:florian] from comment #3)
> Comment on attachment 8957131 [details]
> Bug 1442294 - Downgrade global streaming indicator when a higher priority
> device has been disabled.
> 
> https://reviewboard.mozilla.org/r/226070/#review232042
> 
> The code change looks good. I'll r+ if you can convince me that we already
> have a test covering this case:
> share audio+video, disable video, check sharing indicator, re-enable video,
> check sharing indicator
> or if you add it :-)

This test takes care of that, with the changes to head.js

https://searchfox.org/mozilla-central/rev/588d8120aa11738657da93e09a03378bcd1ba8ec/browser/base/content/test/webrtc/browser_devices_get_user_media_paused.js#18

Thanks!

Comment 5

[Florian Quèze [:florian]]

Comment on attachment 8957131 [details]
Bug 1442294 - Downgrade global streaming indicator when a higher priority device has been disabled.

https://reviewboard.mozilla.org/r/226070/#review232166

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2a403dec22d8
Downgrade global streaming indicator when a higher priority device has been disabled. r=florian

Comment 7

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/2a403dec22d8

Comment 8

[Daniel_A[:daschilean] [Please contact - [e-mail]]]

I verified this issue on Mac OS X 10.12, Ubuntu 16.04, Windows 10 with FF Nightly 60.0a1(2018-03-12) and I can't reproduce this issue anymore. I also verified this issue on Nightly 60.0a1(2018-03-01) and I was able to reproduce it. Based on the the results mentioned above, I will mark this as verified fixed.