1442314 - --separator-border-image is defined as a gradient but used as a border-image

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

The CSS property for --separator-border-image is defined as a gradient, but used as a border-image, which means that it is using incorrect syntax for the rule, and thus the rule is ignored.

Per bug 1441882 comment 13, it should be `border-image: var(--separator-border-image) 1 1;`.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Bug 1441882 added a test that catches these types of errors. When fixing this, the entry for this bug will need to be removed from the whitelist in browser_parsable_css.js.

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1442314 - --separator-border-image is defined as a gradient but used as a border-image.

Review commit: https://reviewboard.mozilla.org/r/224762/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/224762/

Comment 3

[Brian Grinstead [:bgrins]]

Comment on attachment 8955677 [details]
Bug 1442314 - --separator-border-image is defined as a gradient but used as a border-image.

https://reviewboard.mozilla.org/r/224762/#review230792

Thanks! Please update the commit message to state the fix instead of the problem

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5c3844e6f062
Fix the gradient syntax in border-image of --separator-border-image in toolbars.css. r=bgrins

Comment 5

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/5c3844e6f062