1442393 - Comments in self-test/assertRecoveredOnBailout-1.js

Status: NEW

(Core :: JavaScript Engine, enhancement, P3)

Comment 1

[Jason Orendorff [:jorendorff]]

Attachment: Add more comments in assertRecoveredOnBailout-1.js

Comment 2

[Nicolas B. Pierron [:nbp]]

Comment on attachment 8955302 [details] [diff] [review]
Add more comments in assertRecoveredOnBailout-1.js

Review of attachment 8955302 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit-test/tests/self-test/assertRecoveredOnBailout-1.js
@@ +11,2 @@
>  {
> +    // Ion is disabled, or we're running under an option that interferes withx

nit: with*x*

@@ -18,4 @@
>  
> -// Check that we entered Ion succesfully.
> -if (res !== true)
> -    crash("Cannot enter IonMonkey");

We have to keep this test precisely.

inIon can return true-ish values to avoid infinite loops in some gczeal configurations. For example it might returns a string saying that it gives up, which is true-ish and exists the previous loop.

This loop and test are used to skip this test case if we are never able to finish any Ion compilations, due to other unknown configurations.

@@ +37,3 @@
>  
> +// If we get here, the test failed: IonMonkey compiled f without crashing.
> +throw new Error("assertRecoveredOnBailout did not crash as expected");

nit: Can you include the result of f(), which might be a boolean or a string, this might help debug some failures if this happens.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.