1442404 - Crash in mozilla::NrUdpSocketIpc::create

Status: RESOLVED FIXED

(Core :: WebRTC, defect, P2)

Description

[Marcia Knous [:marcia]]

This bug was filed from the Socorro interface and is
report bp-32cbb3f3-354d-46f4-a376-e97810180301.
=============================================================

Harvested a URL from crash stats and could reproduce this Mac crash. 

STR:
1. Load https://jsfiddle.net/jib1/6120zyvL/1/
2. Crash (sometimes you have to reload)

Top 10 frames of crashing thread:

0 XUL mozilla::NrUdpSocketIpc::create dist/include/nsIEventTarget.h:37
1 XUL mozilla::NrSocketBase::CreateSocket media/mtransport/nr_socket_prsock.cpp:2185
2 XUL nr_socket_local_create media/mtransport/nr_socket_prsock.cpp:2201
3 XUL nr_ice_component_initialize media/mtransport/third_party/nICEr/src/ice/ice_component.c:228
4 XUL nr_ice_media_stream_initialize media/mtransport/third_party/nICEr/src/ice/ice_media_stream.c:137
5 XUL nr_ice_gather media/mtransport/third_party/nICEr/src/ice/ice_ctx.c:825
6 XUL mozilla::NrIceCtx::StartGathering media/mtransport/nricectx.cpp:971
7 XUL mozilla::PeerConnectionMedia::EnsureIceGathering_s media/webrtc/signaling/src/peerconnection/PeerConnectionMedia.cpp:1036
8 XUL mozilla::runnable_args_memfn<RefPtr<mozilla::PeerConnectionMedia>, void  media/mtransport/runnable_utils.h:85
9 XUL nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1040

=============================================================

Comment 1

[Andreas Pehrson [:pehrsons]]

Nils, could you find someone to take this? Seems rollback related.

Comment 2

[Byron Campen [:bwc]]

Pretty sure this is what is causing bug 1290856 right now.

Comment 3

[(not currently active) Ted Mielczarek]

I picked a random log from the latest war on orange link in that bug:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1290856&startday=2018-02-26&endday=2018-03-04&tree=all

https://treeherder.mozilla.org/logviewer.html#?repo=autoland&job_id=164256106&lineNumber=5262

and it does have:
[task 2018-02-26T02:25:32.321Z] 02:25:32     INFO - PROCESS-CRASH | Main app process exited normally | application crashed [@ mozilla::NrUdpSocketIpc::create]

So running test_peerConnection_localRollback.html under rr chaos mode might be a good place to start.

Comment 4

[Byron Campen [:bwc]]

Ugh. This is a reentrancy bug. This call spins the STS thread:

https://searchfox.org/mozilla-central/source/media/mtransport/nr_socket_prsock.cpp#236

Comment 5

[Byron Campen [:bwc]]

Attachment: Bug 1442404: Don't spin STS when shutting down the mtransport thread.

Review commit: https://reviewboard.mozilla.org/r/225452/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/225452/

Comment 6

[Byron Campen [:bwc]]

Comment on attachment 8956541 [details]
Bug 1442404: Don't spin STS when shutting down the mtransport thread.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/225452/diff/1-2/

Comment 7

[Nils Ohlmeier [:drno]]

Comment on attachment 8956541 [details]
Bug 1442404: Don't spin STS when shutting down the mtransport thread.

https://reviewboard.mozilla.org/r/225452/#review231408

LGTM

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/82b7012c02bc
Don't spin STS when shutting down the mtransport thread. r=drno

Comment 9

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/82b7012c02bc