1442411 - on Mac, user can be prompted when OS-level access to location services is denied

Status: RESOLVED DUPLICATE of bug 1529591

(Core :: DOM: Geolocation, defect, P5)

Description

[Dietrich Ayala (:dietrich)]

Not sure what the right thing to do here is, but status quo doesn't seem right:

1. open Security & Privacy pref pane

2. in the Location Services section, make sure Firefox Nightly is unchecked

3. open Firefox Nightly, with a web page that does:

navigator.geolocation.getCurrentPosition(console.log, console.error)

4. when prompted for geolocation access, hit ok

Expected: I'm not sure, but definitely not the current situation.

Actual: User is prompted for Geolocation access in Firefox, even though it's not possible to actually give it. Geolocation access not given, even though user said yes.

In console:

PositionError { code: 1, message: "User denied geolocation prompt" }

Secondary issue: The error text isn't really correct. The user said yes, but the OS said no.

We should probably have something that says explicitly that the OS settings aren't allowing access, instead of the regular prompt that gives the illusion that things are all ok.

Comment 1

[Josh Matthews [:jdm]]

We could use https://developer.apple.com/documentation/corelocation/cllocationmanager/1423523-authorizationstatus?language=objc to determine if the system is denying access to the location service. If we check in the Startup method (https://searchfox.org/mozilla-central/source/dom/system/mac/CoreLocationLocationProvider.mm#172) and return an error code, the user shouldn't be prompted at all.