Closed Bug 1442473 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 9738 - [css-typed-om] Whitelist supported properties.

Categories

(Testing :: web-platform-tests, enhancement, P3)

enhancement

Tracking

(firefox61 fixed)

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: mozilla.org, Unassigned)

Details

(Whiteboard: [wptsync downstream error])

Sync web-platform-tests PR 9738 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/w3c/web-platform-tests/pull/9738
Details from upstream follow.

Darren Shen wrote:
>  [css-typed-om] Whitelist supported properties.
>  
>  This patch whitelists all our supported properties. Any property that
>  is not supported will return a base CSSStyleValue. This ensures that
>  we don't accidentally produce unexpected results for properties that
>  we haven't tested it.
>  
>  We also add a few new properties to support, bringing the total number
>  of property tests to 50. We also remove support for 'z-index' because
>  it uses <integers> which we don't support yet.
>  
>  transition-duration is failing tests because we currently convert
>  ms to seconds when we compute, which is incorrect.
>  
>  Some paint/layout tests depend on properties that are not whitelisted,
>  so we've changed them:
>  - border-radius -> margin-left
>  - align-items -> empty-cell
>  
>  Bug: 816402
>  Change-Id: I84d2fd8a15df92624122f0c1ecf4f7c42f928928
>  
>  Reviewed-on: https://chromium-review.googlesource.com/942651
>  WPT-Export-Revision: 9e73633f419f16c776f8bc8b33a104ddeee25740
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6230b8c93507
[wpt PR 9738] - [css-typed-om] Whitelist supported properties., a=testonly
https://hg.mozilla.org/mozilla-central/rev/6230b8c93507
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.