Closed Bug 1442474 Opened 6 years ago Closed 2 years ago

Add support for window progress in Linux Cinnamon desktop using libxapp

Categories

(Thunderbird :: OS Integration, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: ovari123, Unassigned)

References

Details

Attachments

(1 obsolete file)

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:58.0) Gecko/20100101 Firefox/58.0
Build ID: 20180209193630

Steps to reproduce:

Linux Mint 18.3 includes "Window Progress" as it was implemented in Cinnamon 3.6
https://www.linuxmint.com/rel_sylvia_cinnamon_whatsnew.php

Add Thunderbird Window Progress support
Add TaskbarProgress implementation for gtk3/x11

https://bugzilla.mozilla.org/show_bug.cgi?id=1418749
Component: Untriaged → OS Integration
See Also: → 1418749
(In reply to Wayne Mery (:wsmwk))
Are you able to change the status of this bug from UNCONFIRMED to NEW? Thank you
(In reply to Óvári from comment #1)
> (In reply to Wayne Mery (:wsmwk))
> Are you able to change the status of this bug from UNCONFIRMED to NEW? Thank you

Generally unnecessary for enhancement bugs, but I will do so
Severity: normal → enhancement
Status: UNCONFIRMED → NEW
Ever confirmed: true
I'll have a look at this - since it's been implemented in gecko/widget code, it looks like just a couple of JS-side changes are needed.
(In reply to Michael Webster from comment #3)
Thank you Mike!

Does that mean the window progress will work whenever there is a ProgressBar? For example
1. sending a large email
2. downloading emails
3. Mail Merge add-on

Thank you once again
(In reply to Michael Webster from comment #3)
Can you change the Assignee from Unassigned to yourself?
Should people who are cc'd into Bug 1418749 and work on Thunderbird and not currently listed on this bug be cc'd into this bug? For example (sorry if someone was missed)
JörgK
Richard Marti (:Paenglab)

Thank you
No need to CC me. I'm watching this component.

If somebody would be needed, then it's aceman. To work in TB it would probably needed to port DownloadsTaskbar.jsm.

Aceman, you worked already on the download code, what do you think?
Attached patch test.patch (obsolete) — Splinter Review
I took a look - I guess there is no current taskbar support in Thunderbird (except, it seems, for spawned browser windows?)  I tried on a windows machine as well to be certain.

The only thing I might consider if it does get implemented, is to maybe unify the "are we windows? are we mac? are we gtk?" stuff related to fetching the correct nsITaskbarProgress instance into a single file, and have all current users just call e.g. getAppropriateTaskbarProgress().  I see this pattern repeated in at least three places currently (one in gecko, two in comm, with three different styles) and if another place is added I think it'd be worthwhile.
Attachment #8959753 - Attachment is obsolete: true
Sorry, a few more thoughts... I'm wondering if it's necessary to have this for anything other than possibly the sending of messages.

For myself, I'm usually using imap or have some interval to check new mail.  I'm not sure I'd want the distraction of this feature in my taskbar/wherever, at regular intervals.  If I'm someone who doesn't auto-update, I'm focusing Thunderbird and fetching my mail, in which case, maybe the built-in progress bar is enough.

Maybe if it could be made selective enough to only operate during user-driven actions (sending mail, explicitly checking for mail) but not for periodic updates.
(In reply to Michael Webster from comment #9)
> Sorry, a few more thoughts... I'm wondering if it's necessary to have this
> for anything other than possibly the sending of messages.

Mail Redirect is a way of sending messages. Please show in the Panel in Linux Mint (known as the Taskbar in Windows) the progress of the Mail Redirect add-on when redirecting messages. There currently is a progress bar in Mail Redirect.
https://addons.mozilla.org/thunderbird/addon/mailredirect/

Mail Merge is a way of generating and sending messages. Please show in the Panel in Linux Mint (known as the Taskbar in Windows) the progress of the Mail Merge add-on when generating emails. There currently is a progress bar in Mail Merge. The time to generate emails can take some time as a delay can be set.
https://addons.mozilla.org/thunderbird/addon/mail-merge/

Fixed Outlook import
https://www.mozilla.org/en-US/thunderbird/58.0beta/releasenotes/
It could also be used for the import of messages from another program.

It could also be used for the import of contacts. The CardBook add-on has a progress bar when importing contacts.
https://addons.mozilla.org/thunderbird/addon/cardbook/

> For myself, I'm usually using imap or have some interval to check new mail. 
> I'm not sure I'd want the distraction of this feature in my
> taskbar/wherever, at regular intervals.  If I'm someone who doesn't
> auto-update, I'm focusing Thunderbird and fetching my mail, in which case,
> maybe the built-in progress bar is enough.
>
> Maybe if it could be made selective enough to only operate during
> user-driven actions (sending mail, explicitly checking for mail) but not for
> periodic updates.

One benefit of showing the checking of new mail (even if it is automatic) is to help ensure that Thunderbird is not closed while messages are being downloaded.

What do you think?

Thank you
LibreOffice cross-reference:
https://bugs.documentfoundation.org/show_bug.cgi?id=116783

What do you think? (see also comment 7)

Flags: needinfo?(acelists)

Sorry, not for me in the foreseeable future.

Flags: needinfo?(acelists)
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: