Closed
Bug 1442500
Opened 5 years ago
Closed 5 years ago
Rename editor/txtsvc to editor/spellchecker
Categories
(Core :: DOM: Editor, enhancement, P3)
Core
DOM: Editor
Tracking
()
RESOLVED
FIXED
mozilla60
Tracking | Status | |
---|---|---|
firefox60 | --- | fixed |
People
(Reporter: m_kato, Assigned: m_kato)
Details
Attachments
(3 files)
No description provided.
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → m_kato
Assignee | ||
Updated•5 years ago
|
Summary: Rename editor/txtsvcs to editor/spellchecker → Rename editor/txtsvc to editor/spellchecker
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 4•5 years ago
|
||
mozreview-review |
Comment on attachment 8955405 [details] Bug 1442500 - Part 1. Rename editor/txtsvc to editor/spellchecker. https://reviewboard.mozilla.org/r/224566/#review230554
Attachment #8955405 -
Flags: review?(masayuki) → review+
Comment 5•5 years ago
|
||
mozreview-review |
Comment on attachment 8955406 [details] Bug 1442500 - Part 2. Move some spellchecker source files in /editor/composer to /editor/spellchecker. https://reviewboard.mozilla.org/r/224568/#review230556 ::: editor/composer/moz.build:34 (Diff revision 1) > > # Needed because we include HTMLEditor.h which indirectly includes nsDocument.h > LOCAL_INCLUDES += [ > '/dom/base', > '/dom/html', # For nsHTMLDocument > + '/editor/spellchecker', # nsComposeTxtSrvFilter.h If we need this line, perhaps, all headers which are required by this folder should be exposed.
Attachment #8955406 -
Flags: review?(masayuki) → review+
Comment 6•5 years ago
|
||
mozreview-review |
Comment on attachment 8955407 [details] Bug 1442500 - Part 3. Move spellchecker tests to editor/spellchecker. https://reviewboard.mozilla.org/r/224570/#review230558 If the moving tests causes orange, summary of tracking bugs should be updated with the new path. Please modified them after landed those patches.
Attachment #8955407 -
Flags: review?(masayuki) → review+
Assignee | ||
Comment 7•5 years ago
|
||
mozreview-review-reply |
Comment on attachment 8955406 [details] Bug 1442500 - Part 2. Move some spellchecker source files in /editor/composer to /editor/spellchecker. https://reviewboard.mozilla.org/r/224568/#review230556 > If we need this line, perhaps, all headers which are required by this folder should be exposed. At finally, I will remove this filter. This interface is used by mail cite mode or not for spell check.
Pushed by m_kato@ga2.so-net.ne.jp: https://hg.mozilla.org/integration/autoland/rev/dc7e03212107 Part 1. Rename editor/txtsvc to editor/spellchecker. r=masayuki https://hg.mozilla.org/integration/autoland/rev/b2e381dcef74 Part 2. Move some spellchecker source files in /editor/composer to /editor/spellchecker. r=masayuki https://hg.mozilla.org/integration/autoland/rev/1e2f56a1e4b4 Part 3. Move spellchecker tests to editor/spellchecker. r=masayuki
Comment 9•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/dc7e03212107 https://hg.mozilla.org/mozilla-central/rev/b2e381dcef74 https://hg.mozilla.org/mozilla-central/rev/1e2f56a1e4b4
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in
before you can comment on or make changes to this bug.
Description
•