1442500 - Rename editor/txtsvc to editor/spellchecker

Status: RESOLVED FIXED

(Core :: DOM: Editor, enhancement, P3)

Comment 1

[Makoto Kato [:m_kato]]

Attachment: Bug 1442500 - Part 1. Rename editor/txtsvc to editor/spellchecker.

txtsvc is ambiguous name, so we should use functional name instead.

XPIDL_MODULE still keeps 'txtsvc' because 'spellchecker' is already used by
extensions/spellchek/idl.  And all IDLs for editor may move to /editor since
most IDLs for editor is on /editor.

Review commit: https://reviewboard.mozilla.org/r/224566/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/224566/

Comment 2

[Makoto Kato [:m_kato]]

Attachment: Bug 1442500 - Part 2. Move some spellchecker source files in /editor/composer to /editor/spellchecker.

Per bug 1439813, some files in composer is for spellchecker, so we should move
it to /editor/spellchecker.

Review commit: https://reviewboard.mozilla.org/r/224568/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/224568/

Comment 3

[Makoto Kato [:m_kato]]

Attachment: Bug 1442500 - Part 3. Move spellchecker tests to editor/spellchecker.

Many tests in composer are for spellchecker, so we should move it to
/editor/spellchecker/tests.

Review commit: https://reviewboard.mozilla.org/r/224570/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/224570/

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8955405 [details]
Bug 1442500 - Part 1. Rename editor/txtsvc to editor/spellchecker.

https://reviewboard.mozilla.org/r/224566/#review230554

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8955406 [details]
Bug 1442500 - Part 2. Move some spellchecker source files in /editor/composer to /editor/spellchecker.

https://reviewboard.mozilla.org/r/224568/#review230556

::: editor/composer/moz.build:34
(Diff revision 1)
>  
>  # Needed because we include HTMLEditor.h which indirectly includes nsDocument.h
>  LOCAL_INCLUDES += [
>      '/dom/base',
>      '/dom/html',  # For nsHTMLDocument
> +    '/editor/spellchecker', # nsComposeTxtSrvFilter.h

If we need this line, perhaps, all headers which are required by this folder should be exposed.

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8955407 [details]
Bug 1442500 - Part 3. Move spellchecker tests to editor/spellchecker.

https://reviewboard.mozilla.org/r/224570/#review230558

If the moving tests causes orange, summary of tracking bugs should be updated with the new path. Please modified them after landed those patches.

Comment 7

[Makoto Kato [:m_kato]]

Comment on attachment 8955406 [details]
Bug 1442500 - Part 2. Move some spellchecker source files in /editor/composer to /editor/spellchecker.

https://reviewboard.mozilla.org/r/224568/#review230556

> If we need this line, perhaps, all headers which are required by this folder should be exposed.

At finally, I will remove this filter.  This interface is used by mail cite mode or not for spell check.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dc7e03212107
Part 1. Rename editor/txtsvc to editor/spellchecker. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/b2e381dcef74
Part 2. Move some spellchecker source files in /editor/composer to /editor/spellchecker. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/1e2f56a1e4b4
Part 3. Move spellchecker tests to editor/spellchecker. r=masayuki

Comment 9

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/dc7e03212107
https://hg.mozilla.org/mozilla-central/rev/b2e381dcef74
https://hg.mozilla.org/mozilla-central/rev/1e2f56a1e4b4