1442536 - ARM64 simulator: Implement single-step profiling

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, enhancement, P3)

Description

[Lars T Hansen [:lth]]

Single-step profiling is used by several of the test cases and we can probably implement this fairly easily in the simulator (it is currently available on ARM and MIPS64).

Rough work order:

- enable in shell/jsshell.h (easy)
- need hooks to read registers in js.cpp in SingleStepCallback (easy)
- support single-stepping in simulator itself (a bit harder)
- unknown wrinkles

Comment 1

[Nicolas B. Pierron [:nbp]]

Attachment: arm64.gdb

For your information, I do not think this is necessary. I have been debugging using the simulator with the following gdb file to be sourced when I start debugging a process with the ARM64 simulator and this works like a charm. The only trick is that to make it work with rr, you have to use rcc instead of rc.

This file adds a breakpoint at the location where the simulator is stepping, and enabling/disabling and displays the ARM64 instruction each time. The value of the registers are made available in the $x__ variables.

If needed we can move this file in the tree for a better debugging experience, but I do not think we need to add some interactive mode as part of the Simulator. From my experience, these interactive mode are worse than any integrated experience within gdb.

Comment 2

[Nicolas B. Pierron [:nbp]]

Since we all got ARM64 devices on hand, and the arm64.gdb script from the previous comment gives us enough tooling on top of the simulator, the simulator profiling (tracing) is no longer necessary.

Comment 3

[Yury Delendik (:yury)]

We need this (for wasm stuff). I'll reopen it.

Comment 4

[Yury Delendik (:yury)]

Attachment: Bug 1442536 - Implement single-step profiling for arm64. r?jandem

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/58b486985f5e
Implement single-step profiling for arm64. r=jandem

Comment 6

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/58b486985f5e