Closed Bug 1442547 Opened 2 years ago Closed 2 years ago
In high contrast theme, selection of one site under "Settings - Cookies and Site Date" dialog is not visible
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60 Build ID 20180301223350 [Affected versions]: Nightly 60.0a1 [Affected platforms]: Windows 10 x64, Windows 7 x32 [Steps to reproduce]: 1. Set up your windows with a High Contrast theme (Go to Personalise → Themes → Theme Settings and activate a High Contrast Theme.) 2. Launch Nightly 60.0a1 with a new profile 3. Open few web pages in new tabs (youtube.com, facebook.com, www.wikipedia.org, www.reddit.com) 4. Go to about:preferences#privacy 5. At Cookies and Site Data section click on Settings button. 6. Under the Settings - Cookies and Site Data dialog, select one of the sites from the table. [Expected results]: The website should be selected and selection should be visible to the user. [Actual result]: The selection is not visible to the end user.(see screenshot)
This is not a new regression, right?
So, the "Settings - Cookies and Site Data" dialog was introduced with the Site Storage UI Redesign implementation. This is why I did not mention if this is a regression or not. But if we consider this dialog the next level of "Settings - Site Data" dialog, then this is not a new regression. On the "Settings - Site Data" dialog from an older version of Firefox(57) the behavior is the same.
Priority: -- → P2
Whiteboard: [storage-v2][triage] → [storage-v2]
Assignee: nobody → jhofmann
Status: NEW → ASSIGNED
Priority: P2 → P1
Comment on attachment 8966192 [details] Bug 1442547 - Show site data manager selection in high contrast mode. https://reviewboard.mozilla.org/r/234940/#review240618
Attachment #8966192 - Flags: review?(dao+bmo) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/30228244beaf Show site data manager selection in high contrast mode. r=dao
Comment on attachment 8966192 [details] Bug 1442547 - Show site data manager selection in high contrast mode. Approval Request Comment [Feature/Bug causing the regression]: Original implementation [User impact if declined]: Site data manager not really usable in high contrast mode. [Is this code covered by automated tests?]: No [Has the fix been verified in Nightly?]: Not yet AFAICS [Needs manual test from QE? If yes, steps to reproduce]: See comment 0 [List of other uplifts needed for the feature/fix]: None [Is the change risky?]: No [Why is the change risky/not risky?]: A few lines of CSS that are isolated to that dialog [String changes made/needed]: None
Attachment #8966192 - Flags: approval-mozilla-beta?
I reproduced this issue using Fx 57.0a1 (2017-09-21) on Windows 10 x64. I can confirm this issue is fixed, I verified using Fx 61.0a1, (build ID: 20180415220108) on Windows 10 x64.
Comment on attachment 8966192 [details] Bug 1442547 - Show site data manager selection in high contrast mode. small css fix for prefs, verified in nightly, approved for 60.0b14
Attachment #8966192 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
I can confirm this issue is fixed, I verified using Fx 60.0b16, on Windows 10 x64.
You need to log in before you can comment on or make changes to this bug.