1442597 - Can't drag the Mobile Bookmarks folder

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Mark Banner (:standard8)]

This is a regression from bug 1423896 - all the "All Bookmarks" folders should be able to be copied to another folder, however the Mobile Bookmarks folder cannot be dragged at the moment.

This is a simple fix as I'd missed including it in one of the functions.

Comment 1

[Lina Butler [:lina]]

How do you feel about going the other way and disabling copying of "All Bookmarks" and its "children"? On the one hand, it makes sense we treat them like any other folder or query; on the other, this makes it easy to create confusing cycles in the UI if you, for example, drag "All Bookmarks" into the menu or toolbar.

Comment 2

[Mark Banner (:standard8)]

Marco & I discussed changing how copy & paste worked, and we decided for now to keep it the same. It can lead to confusing UI, and we don't know if people rely on it or not (hopefully not but...). We're hoping for a library window re-design sometime so this may go away anyway.

Comment 3

[Mark Banner (:standard8)]

Attachment: Bug 1442597 - Can't drag/copy the Mobile bookmarks folder shortcut.

Review commit: https://reviewboard.mozilla.org/r/224680/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/224680/

Comment 4

[Marco Bonardo [:mak]]

Comment on attachment 8955524 [details]
Bug 1442597 - Can't drag/copy the Mobile bookmarks folder shortcut.

https://reviewboard.mozilla.org/r/224680/#review230696

::: browser/components/places/tests/browser/browser_copy_query_without_tree.js:69
(Diff revision 1)
> +  let mobileCopyNode = library.ContentTree.view.view.nodeForTreeIndex(0);
> +  is(mobileCopyNode.type,
> +     Ci.nsINavHistoryResultNode.RESULT_TYPE_FOLDER_SHORTCUT,
> +     "copy is still a folder shortcut");
> +
> +  PlacesUtils.bookmarks.removeItem(mobileCopyNode.itemId);

ARGH!

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 8955524 [details]
Bug 1442597 - Can't drag/copy the Mobile bookmarks folder shortcut.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/224680/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a170c4ecc80d
Can't drag/copy the Mobile bookmarks folder shortcut. r=mak

Comment 7

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/a170c4ecc80d

Comment 8

[Tom Bannister]

Can no longer reproduce this issue on Firefox Nightly 60.0b16 (20180427210249) on Windows 10x64.

[bugday-20180502]

Comment 9

[Tom Bannister]

(In reply to Tom Bannister from comment #8)
> (20180427210249)

Apologies, posted wrong build ID

(20180426170554)