1442703 - Tabs are restored in reverse order after changing browser.tabs.insertAfterCurrent

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect, P1)

Description

[Kumar McMillan [:kumar]]

After toggling browser.tabs.insertAfterCurrent (see bug 1344749) and restarting Firefox, my tabs were restored in reverse order.

STR (using macOS, maybe others):

- Open Nightly in a new profile
- Go to preferences and set Show your windows and tabs from last time
- Open a bunch of tabs
- Restart Nightly
- Go to about:config, void the warranty, and set browser.tabs.insertAfterCurrent to true
- Restart Nightly

Expected:
The tabs should maintain their left-to-right order

Actual:
The tabs are restored in reverse order -- the rightmost tab from the last session becomes the leftmost tab.

Comment 1

[Dão Gottwald [:dao]]

[Tracking Requested - why for this release]: this seems pretty bad, we probably can't ship bug 1344749 like this

Comment 2

[Bob Silverberg [:bsilverberg]]

(In reply to Dão Gottwald [::dao] from comment #1)
> [Tracking Requested - why for this release]: this seems pretty bad, we
> probably can't ship bug 1344749 like this

Agreed. I think we need to back out 1344749 for now as this isn't the only regression caused by that bug.

Comment 3

[Dão Gottwald [:dao]]

fixed by backout