1442724 - Use keydown instead of keypress to trigger display of the debugging panel

Status: RESOLVED FIXED

(Firefox :: WebPayments UI, enhancement, P1)

Description

[Sam Foster [:sfoster] (he/him)]

Bug 1440189 removes the dispatch of keypress events for non-printable characters (such as the ctrl+alt+d sequence we use to show the debugging panel), and recommends using keydown instead for these cases.

Comment 1

[Sam Foster [:sfoster] (he/him)]

Attachment: Bug 1442724 - Use keydown to trigger display of payments debugging panel.

Review commit: https://reviewboard.mozilla.org/r/224720/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/224720/

Comment 2

[Matthew N. [:MattN]]

Comment on attachment 8955620 [details]
Bug 1442724 - Use keydown to trigger display of payments debugging panel.

https://reviewboard.mozilla.org/r/224720/#review230736

::: toolkit/components/payments/res/paymentRequest.js:36
(Diff revision 1)
> -      case "keypress": {
> +      case "keydown": {
>          if (event.code != "KeyD" || !event.altKey || !event.ctrlKey) {
>            break;
>          }

If you've manually tested that this works then r=me. I thought that event.code may differ with keydown but I'm not sure.

Comment 3

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 8955620 [details]
Bug 1442724 - Use keydown to trigger display of payments debugging panel.

https://reviewboard.mozilla.org/r/224720/#review230738

::: toolkit/components/payments/res/paymentRequest.js:36
(Diff revision 1)
> -      case "keypress": {
> +      case "keydown": {
>          if (event.code != "KeyD" || !event.altKey || !event.ctrlKey) {
>            break;
>          }

Yeah, this works fine.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/26fcec5f5ee4
Use keydown to trigger display of payments debugging panel. r=MattN

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/26fcec5f5ee4