Closed Bug 1442724 Opened 2 years ago Closed 2 years ago

Use keydown instead of keypress to trigger display of the debugging panel

Categories

(Firefox :: WebPayments UI, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 60
Tracking Status
firefox60 --- fixed

People

(Reporter: sfoster, Assigned: sfoster)

Details

(Whiteboard: [webpayments])

Attachments

(1 file)

Bug 1440189 removes the dispatch of keypress events for non-printable characters (such as the ctrl+alt+d sequence we use to show the debugging panel), and recommends using keydown instead for these cases.
Comment on attachment 8955620 [details]
Bug 1442724 - Use keydown to trigger display of payments debugging panel.

https://reviewboard.mozilla.org/r/224720/#review230736

::: toolkit/components/payments/res/paymentRequest.js:36
(Diff revision 1)
> -      case "keypress": {
> +      case "keydown": {
>          if (event.code != "KeyD" || !event.altKey || !event.ctrlKey) {
>            break;
>          }

If you've manually tested that this works then r=me. I thought that event.code may differ with keydown but I'm not sure.
Attachment #8955620 - Flags: review?(MattN+bmo) → review+
Comment on attachment 8955620 [details]
Bug 1442724 - Use keydown to trigger display of payments debugging panel.

https://reviewboard.mozilla.org/r/224720/#review230738

::: toolkit/components/payments/res/paymentRequest.js:36
(Diff revision 1)
> -      case "keypress": {
> +      case "keydown": {
>          if (event.code != "KeyD" || !event.altKey || !event.ctrlKey) {
>            break;
>          }

Yeah, this works fine.
Pushed by sfoster@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/26fcec5f5ee4
Use keydown to trigger display of payments debugging panel. r=MattN
https://hg.mozilla.org/mozilla-central/rev/26fcec5f5ee4
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Assignee: nobody → sfoster
Priority: -- → P1
Whiteboard: [webpayments]
Product: Toolkit → Firefox
Target Milestone: mozilla60 → Firefox 60
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.