1442749 - Starting Firefox with -private-window <url> launches a second non private window

Status: VERIFIED FIXED

(Firefox :: Private Browsing, defect)

Description

[slew]

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:59.0) Gecko/20100101 Firefox/59.0
Build ID: 20100101

Steps to reproduce:

* Install latest Firefox 60, run it (or don't)
* Attempt to open Firefox with firefox.exe -private-window example.com


Actual results:

A new private window opens with example.com.
A second non private window opens on top of the requested page.


Expected results:

The second window should not appear.

Comment 1

[Gingerbread Man]

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0
20180309100425

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=2667f0b010c959940d7a12b4311d54a6abd74ac5&tochange=b2a9a4bb5c94de179ae7a3f52fde58c0e2897498

Suspect: bug 1432355.

I wasn't able to narrow the range any further because I'm currently getting a CloudFront error when trying the inbound and autoland directory listings.

Comment 3

[Mike Kaply [:mkaply]]

Attachment: Bug 1442749 - Add back line accidentally removed in bug 1432355.

Review commit: https://reviewboard.mozilla.org/r/226614/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/226614/

Comment 4

[Mike Kaply [:mkaply]]

Accidentally removed a needed line on the policy checkin.

Comment 5

[:Gijs (he/him)]

Comment on attachment 8957694 [details]
Bug 1442749 - Add back line accidentally removed in bug 1432355.

https://reviewboard.mozilla.org/r/226614/#review232476

How did this slip in? The cset I reviewed didn't remove this, and this was autolanded. So how did we end up with a revision that removed this on mozreview? :-\

Unfortunately the interdiff reviewboard provides on the old patch is no use for determining this at all because it crosses a rebase so 99% of it is unrelated junk.

Comment 6

[:Gijs (he/him)]

Also, could you file a follow-up to add marionette / firefox-ui-functional tests for the commandline handlers?

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/010b589f89a0
Add back line accidentally removed in bug 1432355. r=Gijs

Comment 8

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/010b589f89a0

Comment 9

[Abe - QA (:Abe_LV)]

It is verified as fixed. Only one private window appears this time.

Screen capture- https://testing-1.tinytake.com/sf/MjQzMDM5Ml83MzU0Mjg1

If "DisablePrivateBrowsing" policy is active, a normal window appears and it navigates to about:privatebrowsing (which is blocked by the policy).

Comment 10

[Abe - QA (:Abe_LV)]

Nightly 61.0a1 and Build ID-20180312134431 is used for testing.

Comment 12

[:Gijs (he/him)]

(In reply to :Gijs from comment #6)
> Also, could you file a follow-up to add marionette / firefox-ui-functional
> tests for the commandline handlers?

Mike, did this happen?

Comment 13

[Mike Kaply [:mkaply]]

> Mike, did this happen?

Not yet. Was on my list for today. I'll do it now.

Comment 14

[Mike Kaply [:mkaply]]

https://bugzilla.mozilla.org/show_bug.cgi?id=1445674

Comment 15

[Abe - QA (:Abe_LV)]

We also verified this on beta and it is fixed.
Test cases and runs are here- https://testrail.stage.mozaws.net/index.php?/plans/view/8760