Closed Bug 1442750 Opened 2 years ago Closed Last year

Silence a few Clang-only warnings in SM

Categories

(Core :: JavaScript Engine, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: jorendorff, Assigned: jorendorff)

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
The changes in shell/js.cpp silence warnings about unreachable return
statements.

The constant being removed in testErrorInterceptor.cpp is unused.
Attachment #8955665 - Flags: review?(dteller)
Assignee: nobody → jorendorff
Status: NEW → ASSIGNED
Comment on attachment 8955665 [details] [diff] [review]
Slience a few Clang-only warnings in SpiderMonkey

Review of attachment 8955665 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/shell/js.cpp
@@ -689,5 @@
>              buffer = tmp;
>          }
>          current = buffer + len;
>      } while (true);
> -    return nullptr;

Wouldn't it have been sufficient to remove this single line?
Attachment #8955665 - Flags: review?(dteller) → review+
Priority: -- → P3
Yes.
The changes in shell/js.cpp silence warnings about unreachable return
statements.

The constant being removed in testErrorInterceptor.cpp is unused.
Attachment #8955665 - Attachment is obsolete: true
Attachment #9005212 - Flags: review+
Keywords: checkin-needed
Pushed by nbeleuzu@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1289f17ab75d
Slience a few Clang-only warnings in SpiderMonkey. r=jorendorff
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/1289f17ab75d
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.