Closed Bug 1442755 Opened 2 years ago Closed 2 years ago

[CSD] Titlebar does not visually distinguish between active and inactive windows

Categories

(Core :: Widget: Gtk, defect)

60 Branch
Unspecified
Linux
defect
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla64
Tracking Status
firefox64 --- wontfix
firefox65 --- verified

People

(Reporter: blokowski420, Assigned: stransky)

References

(Blocks 1 open bug)

Details

Attachments

(4 files, 1 obsolete file)

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0
Build ID: 20180301024724

Steps to reproduce:

1. Open Firefox
2. Go to about:config and set browser.tabs.drawInTitlebar to 'true'
3. Open a different application (for example Nautilus or a Terminal)
4. Switch back and forth between the two applications (alt+tab)


Actual results:

The Firefox titlebar doesn't change visually, regardless of whether the window is active or inactive.


Expected results:

With many desktop environments and themes there is a visual indication, when a window is inactive.
For example, in GNOME with the Arc GTK theme the window control buttons switch to grayscale and the overall titlebar content is muted (see attachment).
Blocks: gtktitlebar
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Unspecified → Linux
This is partially caused by wrong titlebar style which is solved at Bug 1408360 and also the style is animated which we don't support for the titlebar element.
Assignee: nobody → stransky
Let's fix headerbar in this bug and buttons at Bug 1489963.
Summary: [CSD] Titlebar and window control buttons do not visually distinguish between active and inactive windows → [CSD] Titlebar does not visually distinguish between active and inactive windows
No longer depends on: 1489097
Comment on attachment 9007740 [details]
Bug 1442755 - Redraw titlebar widgets when application focus changes and draw inactive titlebar with GTK_STATE_FLAG_BACKDROP state, r=jhorak

Jan Horak [:jhorak] has approved the revision.
Attachment #9007740 - Flags: review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/19e2c611e889
Redraw titlebar widgets when application focus changes and draw inactive titlebar with GTK_STATE_FLAG_BACKDROP state, r=jhorak
Keywords: checkin-needed
Comment on attachment 9008180 [details]
Bug 1442755 - Redraw titlebar widgets when application focus changes and draw inactive titlebar with GTK_STATE_FLAG_BACKDROP state, r=jhorak

Jan Horak [:jhorak] has approved the revision.
Attachment #9008180 - Flags: review+
Attachment #9007740 - Attachment is obsolete: true
Flags: needinfo?(stransky)
Pushed by ebalazs@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/511150b11de9
Redraw titlebar widgets when application focus changes and draw inactive titlebar with GTK_STATE_FLAG_BACKDROP state, r=jhorak
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/511150b11de9
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Depends on: 1497534
We may disable this at Beta (Firefox 64) as it comes with a visual regressions (Bug 1506050 and Bug 1497534).
Would you mind providing a backout patch for beta?
Flags: needinfo?(stransky)
(In reply to Julien Cristau [:jcristau] from comment #15)
> Would you mind providing a backout patch for beta?

Sure, I'll do that. Keeping needinfo to remind me.
Flags: needinfo?(stransky)
Attachment #9024657 - Flags: review?(jhorak)
Comment on attachment 9024657 [details] [diff] [review]
disable titlebar theming for Firefox 64 (Beta)

Review of attachment 9024657 [details] [diff] [review]:
-----------------------------------------------------------------

Please comment also in nsNativeThemeGTK::WidgetStateChanged, r+ with that fixed.
Attachment #9024657 - Flags: review?(jhorak) → review+
Updated one, thanks.
Comment on attachment 9025562 [details] [diff] [review]
patch for check-in

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1497534

User impact if declined: Back out this Bug for beta as it may cause titlebar appearance regressions (Bug 1497534).

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: No

Needs manual test from QE?: Yes

If yes, steps to reproduce: 1) disable system titlebar (Customize -> Titlebar checkbox)
2) open another application (terminal for instance)
3) switch to it by alt+tab or so and check that firefix titlebar still has active appearance and it's not changed when switching to another apps.

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): Back out of a fix, Linux only.

String changes made/needed:
Attachment #9025562 - Flags: approval-mozilla-beta?
Comment on attachment 9025562 [details] [diff] [review]
patch for check-in

Thanks Martin, approved for 64.0b11
Attachment #9025562 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Whiteboard: [checkin-needed-beta]
Whiteboard: [checkin-needed-beta]
I have managed to reproduce the issue using Fx60.0a1 buildID: 20180301223350 on Ubuntu 16.04.

The issue is verified fixed using Fx65.0b2 and Fx65.0a1 on Ubuntu 16.04. The Firefox window is now correctly set as inactive when it is not the main focus (buttons become greyed out). This was tested using Ambience default theme on Ubuntu.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.