1442755 - [CSD] Titlebar does not visually distinguish between active and inactive windows

Status: VERIFIED FIXED

(Core :: Widget: Gtk, defect)

Description

[3ship]

Attachment: Nautilus - inactive window (top) and active window (bottom)

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0
Build ID: 20180301024724

Steps to reproduce:

1. Open Firefox
2. Go to about:config and set browser.tabs.drawInTitlebar to 'true'
3. Open a different application (for example Nautilus or a Terminal)
4. Switch back and forth between the two applications (alt+tab)


Actual results:

The Firefox titlebar doesn't change visually, regardless of whether the window is active or inactive.


Expected results:

With many desktop environments and themes there is a visual indication, when a window is inactive.
For example, in GNOME with the Arc GTK theme the window control buttons switch to grayscale and the overall titlebar content is muted (see attachment).

Comment 1

[Martin Stránský [:stransky] (ni? me)]

This is partially caused by wrong titlebar style which is solved at Bug 1408360 and also the style is animated which we don't support for the titlebar element.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Let's fix headerbar in this bug and buttons at Bug 1489963.

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1442755 - Redraw titlebar widgets when application focus changes and draw inactive titlebar with GTK_STATE_FLAG_BACKDROP state, r=jhorak

Comment 4

[Jan Horak [:jhorak]]

Comment on attachment 9007740 [details]
Bug 1442755 - Redraw titlebar widgets when application focus changes and draw inactive titlebar with GTK_STATE_FLAG_BACKDROP state, r=jhorak

Jan Horak [:jhorak] has approved the revision.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/19e2c611e889
Redraw titlebar widgets when application focus changes and draw inactive titlebar with GTK_STATE_FLAG_BACKDROP state, r=jhorak

Comment 6

[Cosmin Sabou [:CosminS]]

Backed out for wpt reftest failures.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&fromchange=19e2c611e88918e24f64fc93c4a599432dece8f1&tochange=db2ac775e38ade2e7cbbf4318d5866bafaedc2f6&filter-searchStr=wr&selectedJob=198623978

Backout link: https://hg.mozilla.org/integration/autoland/rev/ee581fe311ed557cc6dde5f510ff93255cf0a9c9

Failure log: 
https://treeherder.mozilla.org/logviewer.html#?job_id=198623978&repo=autoland&lineNumber=24003
https://treeherder.mozilla.org/logviewer.html#?job_id=198624121&repo=autoland&lineNumber=10670

Please also take a look at this failure: https://treeherder.mozilla.org/logviewer.html#?job_id=198621176&repo=autoland&lineNumber=52097

Comment 7

[Martin Stránský [:stransky] (ni? me)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4be135c2d902fd3628af9d60c12cc184ddf13707

Comment 8

[Martin Stránský [:stransky] (ni? me)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6cc8b2d8d25652a923b95790260cb1c8ee2f56f0

Comment 9

[Martin Stránský [:stransky] (ni? me)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9c29bf1f8bb8ea5eccdb8ca00e420ba905e5ea22

Comment 10

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1442755 - Redraw titlebar widgets when application focus changes and draw inactive titlebar with GTK_STATE_FLAG_BACKDROP state, r=jhorak

Comment 11

[Jan Horak [:jhorak]]

Comment on attachment 9008180 [details]
Bug 1442755 - Redraw titlebar widgets when application focus changes and draw inactive titlebar with GTK_STATE_FLAG_BACKDROP state, r=jhorak

Jan Horak [:jhorak] has approved the revision.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/511150b11de9
Redraw titlebar widgets when application focus changes and draw inactive titlebar with GTK_STATE_FLAG_BACKDROP state, r=jhorak

Comment 13

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/511150b11de9

Comment 14

[Martin Stránský [:stransky] (ni? me)]

We may disable this at Beta (Firefox 64) as it comes with a visual regressions (Bug 1506050 and Bug 1497534).

Comment 15

[Julien Cristau [:jcristau]]

Would you mind providing a backout patch for beta?

Comment 16

[Martin Stránský [:stransky] (ni? me)]

(In reply to Julien Cristau [:jcristau] from comment #15)
> Would you mind providing a backout patch for beta?

Sure, I'll do that. Keeping needinfo to remind me.

Comment 17

[Martin Stránský [:stransky] (ni? me)]

Attachment: disable titlebar theming for Firefox 64 (Beta)

Comment 18

[Jan Horak [:jhorak]]

Comment on attachment 9024657 [details] [diff] [review]
disable titlebar theming for Firefox 64 (Beta)

Review of attachment 9024657 [details] [diff] [review]:
-----------------------------------------------------------------

Please comment also in nsNativeThemeGTK::WidgetStateChanged, r+ with that fixed.

Comment 19

[Martin Stránský [:stransky] (ni? me)]

Attachment: patch for check-in

Updated one, thanks.

Comment 20

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 9025562 [details] [diff] [review]
patch for check-in

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1497534

User impact if declined: Back out this Bug for beta as it may cause titlebar appearance regressions (Bug 1497534).

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: No

Needs manual test from QE?: Yes

If yes, steps to reproduce: 1) disable system titlebar (Customize -> Titlebar checkbox)
2) open another application (terminal for instance)
3) switch to it by alt+tab or so and check that firefix titlebar still has active appearance and it's not changed when switching to another apps.

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): Back out of a fix, Linux only.

String changes made/needed:

Comment 21

[Julien Cristau [:jcristau]]

Comment on attachment 9025562 [details] [diff] [review]
patch for check-in

Thanks Martin, approved for 64.0b11

Comment 22

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d810f485f1aa

Comment 23

[Cristian Baica [:cbaica], Release Desktop QA]

I have managed to reproduce the issue using Fx60.0a1 buildID: 20180301223350 on Ubuntu 16.04.

The issue is verified fixed using Fx65.0b2 and Fx65.0a1 on Ubuntu 16.04. The Firefox window is now correctly set as inactive when it is not the main focus (buttons become greyed out). This was tested using Ambience default theme on Ubuntu.