Closed Bug 1442756 Opened 2 years ago Closed 2 years ago

Switch nsHttpAuthCache's mDB to nsClassHashtable

Categories

(Core :: Networking: HTTP, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: erahm, Assigned: erahm)

References

(Blocks 1 open bug)

Details

(Whiteboard: [necko-triaged])

Attachments

(1 file)

We should really avoid using PL_Hash if possible. Converting `mDB` is pretty straightforward.

[1] https://searchfox.org/mozilla-central/rev/61d400da1c692453c2dc2c1cf37b616ce13dea5b/netwerk/protocol/http/nsHttpAuthCache.h#256
Attachment #8955694 - Flags: review?(honzab.moz)
Assignee: nobody → erahm
Status: NEW → ASSIGNED
Comment on attachment 8955694 [details] [diff] [review]
Switch nsHttpAuthCache::mDB to nsClassHashtable

Review of attachment 8955694 [details] [diff] [review]:
-----------------------------------------------------------------

thanks!

::: netwerk/protocol/http/nsHttpAuthCache.cpp
@@ +81,2 @@
>      return NS_OK;
>  }

maybe remove this method?

@@ +214,5 @@
>  nsHttpAuthCache::ClearOriginData(OriginAttributesPattern const &pattern)
>  {
> +    for (auto iter = mDB.Iter(); !iter.Done(); iter.Next()) {
> +        const nsACString& key = iter.Key();
> +        // Extract the origin attributes suffix from the key.

blank line before this line
Attachment #8955694 - Flags: review?(honzab.moz) → review+
Priority: -- → P2
Whiteboard: [necko-triaged]
Priority: P2 → P3
Pushed by erahm@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5705bfa39d3a
Switch nsHttpAuthCache::mDB to nsClassHashtable. r=mayhemer
https://hg.mozilla.org/mozilla-central/rev/5705bfa39d3a
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.