1442756 - Switch nsHttpAuthCache's mDB to nsClassHashtable

Status: RESOLVED FIXED

(Core :: Networking: HTTP, enhancement, P3)

Description

[Eric Rahm [:erahm]]

We should really avoid using PL_Hash if possible. Converting `mDB` is pretty straightforward.

[1] https://searchfox.org/mozilla-central/rev/61d400da1c692453c2dc2c1cf37b616ce13dea5b/netwerk/protocol/http/nsHttpAuthCache.h#256

Comment 1

[Eric Rahm [:erahm]]

Attachment: Switch nsHttpAuthCache::mDB to nsClassHashtable

Comment 2

[Honza Bambas (:mayhemer)]

Comment on attachment 8955694 [details] [diff] [review]
Switch nsHttpAuthCache::mDB to nsClassHashtable

Review of attachment 8955694 [details] [diff] [review]:
-----------------------------------------------------------------

thanks!

::: netwerk/protocol/http/nsHttpAuthCache.cpp
@@ +81,2 @@
>      return NS_OK;
>  }

maybe remove this method?

@@ +214,5 @@
>  nsHttpAuthCache::ClearOriginData(OriginAttributesPattern const &pattern)
>  {
> +    for (auto iter = mDB.Iter(); !iter.Done(); iter.Next()) {
> +        const nsACString& key = iter.Key();
> +        // Extract the origin attributes suffix from the key.

blank line before this line

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5705bfa39d3a
Switch nsHttpAuthCache::mDB to nsClassHashtable. r=mayhemer

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/5705bfa39d3a