Closed
Bug 1442757
Opened 3 years ago
Closed 3 years ago
Forgot to call `sendMessageToContent` helper in "paymentDialogWrapper.js"
Categories
(Firefox :: WebPayments UI, defect, P1)
Firefox
WebPayments UI
Tracking
()
RESOLVED
FIXED
Firefox 60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: jonathanGB, Assigned: jonathanGB)
References
Details
(Whiteboard: [webpayments])
Attachments
(1 file)
https://dxr.mozilla.org/mozilla-central/source/toolkit/components/payments/content/paymentDialogWrapper.js#261-266 This snippet should be replaced with the helper `sendMessageToContent` (https://dxr.mozilla.org/mozilla-central/source/toolkit/components/payments/content/paymentDialogWrapper.js#249).
|
||
Updated•3 years ago
|
Priority: -- → P3
|
Assignee | |
Updated•3 years ago
|
Assignee: nobody → jonathan.guillotte.blouin
| Comment hidden (mozreview-request) |
|
|
||
Comment 2•3 years ago
|
||
| mozreview-review | ||
Comment on attachment 8955726 [details] Bug 1442757 - use `sendMessageToContent` helper. https://reviewboard.mozilla.org/r/224800/#review230828 Thanks Jonathan! ::: commit-message-5a4ca:1 (Diff revision 1) > +Bug 1442757 - use `sendMessageToContent` helper. r=mattn Nit: in the future the commit message could be a bit more descriptive. e.g. adding "in `updateRequest`"
Attachment #8955726 -
Flags: review?(MattN+bmo) → review+
Pushed by mozilla@noorenberghe.ca: https://hg.mozilla.org/integration/autoland/rev/4b3733f7e7f2 use `sendMessageToContent` helper. r=MattN
|
||
Comment 4•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/4b3733f7e7f2
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
|
||
Updated•3 years ago
|
Priority: P3 → P1
Whiteboard: [webpayments]
|
||
Updated•3 years ago
|
Product: Toolkit → Firefox
Target Milestone: mozilla60 → Firefox 60
Version: unspecified → Trunk
You need to log in
before you can comment on or make changes to this bug.
Description
•