1442762 - "Open Pop-up Windows" site permissions' drop-down list items are too narrow

Status: VERIFIED FIXED

(Firefox :: Site Permissions, defect, P3)

Description

[Chris Peterson [:cpeterson]]

Attachment: Open_Pop-up_Windows_permissions_screenshot.jpg

STR:
1. Open http://www.popuptest.com/popuptest1.html
2. Click the site permissions (i) button in the address bar.
3. Click to expand the "Open Pop-up Windows" section's Allow/Block drop-down list.

RESULT:
On Windows, the drop-down list items "Allow" and "Block" are narrower than the drop-down list's header with the arrow. See the attached screenshot.

On macOS, the drop-down list is the correct width, but the list is too far to the left and not aligned with the drop-down list's header.

Comment 1

[Johann Hofmann [:johannh]]

Since Prathiksha doesn't have a Windows machine, we might need to find someone else to look into this.

Comment 2

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: bug.png

Comment 3

[aarushivij]

Hello, can I work on this?
I can reproduce the issue on linux too. (Dropdown has different width compared to header)
Do I need to make drop down's list item width equal to lists header?
Thanks
Aarushi :)

Comment 4

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

I'm not proper person to fully answer this question, so I'm redirecting it Johann Hofmann [:johannh].

Comment 5

[aarushivij]

Attachment: after.png

Hello Johann ,
I was trying to fix the bug.
Is it how it should look?
Shall push the patch once confirmed by you :)
Thanks

Comment 6

[Johann Hofmann [:johannh]]

Yeah, that's about how I would expect things to look, though I guess it depends on the approach :)

Thanks!

Comment 7

[aarushivij]

Okay, Thanks Johann
Shall push the patch :)

Comment 8

[aarushivij]

Attachment: Bug 1442762 - Open Pop-up Windows site permissions drop-down list items are too narrow r=johannh

Comment 9

[Daniel Kolsis]

Hello, this bug does seem to be a regression, as the first builds in which the drop-down was implemented it looked okay, soon after though the drop-down elements changed to the more narrow version. I've tried to find a specific build using mozregression but it seems it can't reach all the builds, however, this is what I've found:

last known good build: 2017-10-26 pushlog
first known bad build: 2017-10-27 pushlog

Comment 10

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

(In reply to Daniel Kolsis from comment #9)

[...] first known bad build: 2017-10-27 pushlog

For this regression changelog, bug #1411290 looks most suspicious.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b3c3f7d0f044
Open Pop-up Windows site permissions drop-down list items are too narrow r=dao

Comment 12

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/b3c3f7d0f044

Comment 13

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Reproduced the issue using Firefox 60.0a1 (20180302220122) on Windows 10x64.
The issue is verified fixed with Firefox 76.0b4 (20200412214314) on Windows 10x64 and ubuntu 18.04.