1442786 - Failed spidermonkey jobs do not upload binaries

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Steve Fink [:sfink] [:s:]]

I was looking through some ancient patches, and found this one that I thought I had already landed. nbp ran into this some time ago, where he was trying to reproduce a try failure but it unhelpfully would not give him the binary that it was using to fail the test. (If I remember correctly, the issue ended up being that try turns off ASLR?)

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Prevent set -e from leaking into calling scripts

Comment 2

[Steve Fink [:sfink] [:s:]]

Argh. Lost my attachment comment.

The problem is that a calling script without set -e was sourcing a script with set -e in it, thus inheriting set -e, and then when tests failed, it bailed out immediately instead of continuing as was intended.

Comment 3

[Nicolas B. Pierron [:nbp]]

Comment on attachment 8955686 [details] [diff] [review]
Prevent set -e from leaking into calling scripts

Review of attachment 8955686 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for catching this issue :)
I learning some Shell scripting too, I did not knew that set could be scoped that way.

> If I remember correctly, the issue ended up being that try turns off ASLR?

Correct.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8799608e5f0b
Prevent set -e from leaking into calling scripts, r=nbp

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/8799608e5f0b