Closed Bug 1442820 Opened 2 years ago Closed 2 years ago

"this is undefined" in UTEventReporting.jsm when clicking the Home button

Categories

(Firefox :: New Tab Page, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 61
Iteration:
61.1 - Mar 26
Tracking Status
firefox-esr52 --- unaffected
firefox58 --- unaffected
firefox59 --- unaffected
firefox60 --- wontfix
firefox61 --- fixed

People

(Reporter: magicp.jp, Assigned: nanj, NeedInfo)

References

Details

Attachments

(1 file)

Steps to reproduce:
1. Launch Nightly
2. Click the Home button

Actual results:
The following error is logged in the browser console.

this is undefined  UTEventReporting.jsm:51
	sendSessionEndEvent resource://activity-stream/lib/UTEventReporting.jsm:51:1
	sendUTEvent resource://activity-stream/lib/TelemetryFeed.jsm:364:7
	endSession resource://activity-stream/lib/TelemetryFeed.jsm:240:5
	onAction resource://activity-stream/lib/TelemetryFeed.jsm:391:9
	_middleware/</< resource://activity-stream/lib/Store.jsm:49:11
	Store/this[method] resource://activity-stream/lib/Store.jsm:28:55
	onActionFromContent resource://activity-stream/lib/ActivityStreamMessageChannel.jsm:87:5
	onNewTabUnload resource://activity-stream/lib/ActivityStreamMessageChannel.jsm:232:5
	onNewTabUnload self-hosted:975:17
	callListeners resource://gre/modules/RemotePageManager.jsm:33:9
	portMessageReceived resource://gre/modules/RemotePageManager.jsm:123:5
	portMessageReceived self-hosted:975:17
	callListeners resource://gre/modules/RemotePageManager.jsm:33:9
	ChromeMessagePort.prototype.message resource://gre/modules/RemotePageManager.jsm:381:3
	<anonymous> self-hosted:975:17


Expected results:
No error


Regression range:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=7a1af2d03c5435747257e43e94af48c4349190ed&tochange=723f97b68476b396cf7336d87e6c7c646c2365b7
Blocks: 1441018
Has Regression Range: --- → yes
Has STR: --- → yes
Version: 59 Branch → Trunk
:emtwo could you take a look at this?
Flags: needinfo?(msamuel)
Assignee: nobody → najiang
Commits pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/3ef24f9bdce2cfe3c4b8559d034da8e92afe5e74
Fix Bug 1442820 - Fix the unbound this in UTEventReporting

https://github.com/mozilla/activity-stream/commit/61fe4cffb7cbeed7cdfd9bcb991d87f87f601f68
Merge pull request #4039 from ncloudioj/bz1442820

Fix Bug 1442820 - Fix the unbound this in UTEventReporting
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Blocks: 1446053
https://hg.mozilla.org/mozilla-central/rev/70fe801fb934
Iteration: --- → 61.1 - Mar 26
Target Milestone: --- → Firefox 61
I have reproduced this bug with Nightly 60.0a1 (2018-03-02) on Windows 10 , 64 Bit ! 

This bug's fix is Verified with latest Nightly !

Build   ID    20180327105613
User Agent    Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0

[bugday-20180328]
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.