1442845 - Add Clipboard to Firefox will save in Private Browser

Status: RESOLVED FIXED

(Firefox :: Private Browsing, enhancement, P5)

Description

[In]

Add Clipboard to "Firefox will save" in Private Browser

Comment 1

[Josh Matthews [:jdm]]

https://searchfox.org/mozilla-central/source/browser/locales/en-US/chrome/browser/aboutPrivateBrowsing.dtd
https://searchfox.org/mozilla-central/source/browser/components/privatebrowsing/content/aboutPrivateBrowsing.xhtml#50

Comment 2

[Luke Crouch [:groovecoder]]

Marking as P3 for general backlog. We will need a bit of UX guidance on terms to use: e.g., "Clipboard data" vs. "Copied Text"

Comment 3

[nikhil]

Hey,I would like work in this issue.if you could provide some insight about this issue,I would love work on this Thanks!

Comment 4

[Josh Matthews [:jdm]]

The goal is to add the note about "copied text" to the dtd file linked in comment 1, and add the name of the new string to the xhtml file from comment 1 along with the other strings that list things that Firefox does not clear. The result should be visible when you open a private window in a modified build.

Comment 5

[nikhil]

Please bear with me,Its my first contribution
  Thing that I understood from your explanation is like creating a variable name(ie., aboutPrivateBrowsing.note.copiedText) and save "Firefox will save in" and then add this variable to xhtml file that you mentioned in comment 1

Comment 6

[Josh Matthews [:jdm]]

That's the idea, yes.

Comment 7

[nikhil]

(In reply to Josh Matthews [:jdm] from comment #6)
> That's the idea, yes.

Like you said,I made variable and added it to xhtml file in div that contains list elements of bookmarks and downloads
What should i do next..

Comment 8

[Josh Matthews [:jdm]]

Have you tried running the build and opening a private window? Do the changes appear? If not, does `./mach build` make a difference?

Comment 9

[nikhil]

(In reply to Josh Matthews [:jdm] from comment #8)
> Have you tried running the build and opening a private window? Do the
> changes appear? If not, does `./mach build` make a difference?

Yes I have run build and then opened the private window. It worked and the changes appeared.

Comment 10

[Josh Matthews [:jdm]]

https://developer.mozilla.org/en-US/docs/Mercurial/Using_Mercurial#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F has documentation about how to submit your changes for review. If it's still unclear, you can get assistance from the #introduction channel on IRC: https://chat.mibbit.com/?url=irc%3A%2F%2Firc.mozilla.org%2F%23introduction

Comment 11

[nikhil]

Attachment: first

Review commit: https://reviewboard.mozilla.org/r/232190/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/232190/

Comment 12

[nikhil]

Attachment: Bug 1442845 - Add Clipboard to Firefox will save in Private Browser

Review commit: https://reviewboard.mozilla.org/r/232192/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/232192/

Comment 13

[Josh Matthews [:jdm]]

Comment on attachment 8963297 [details]
Bug 1442845 - Add Clipboard to Firefox will save in Private Browser

I'm on leave but I don't want to leave this hanging for a month. Ehsan, could you deal with this or redirect it to a frontend reviewer?

Comment 14

[(no longer active)]

Comment on attachment 8963297 [details]
Bug 1442845 - Add Clipboard to Firefox will save in Private Browser

https://reviewboard.mozilla.org/r/232192/#review239452

Hi Nikhil,

Thanks a lot for your patch!  Please see my comment below about the code changes.

Also, do you mind squashing your changes so that all changes show up in a single changeset (right now you have two changesets instead of one).  You can do that using the histedit command as explained here: http://mozilla-version-control-tools.readthedocs.io/en/latest/hgmozilla/firefoxworkflow.html#changing-code-after-reviews

Thanks!

::: browser/locales/en-US/chrome/browser/aboutPrivateBrowsing.dtd:28
(Diff revision 1)
>  <!ENTITY aboutPrivateBrowsing.info.saved.before          "Firefox ">
>  <!ENTITY aboutPrivateBrowsing.info.saved.emphasize       "will save">
>  <!ENTITY aboutPrivateBrowsing.info.saved.after2          " your:">
>  <!ENTITY aboutPrivateBrowsing.info.downloads             "downloads">
>  <!ENTITY aboutPrivateBrowsing.info.bookmarks             "bookmarks">
> +<!ENTITY aboutPrivateBrowsing.info.copiedText            "clipboards">

As Josh mentioned in comment 4, the desired text here is "copied text" not "clipboards".

Comment 15

[irina6793]

Hi, can I work on this?

Comment 16

[Josh Matthews [:jdm]]

(In reply to irina6793 from comment #15)
> Hi, can I work on this?

Yes! Go ahead an submit a patch that addresses comment 4 and comment 14.

Comment 17

[Siddharth Maurya [:savvysiddharth]]

Attachment: Added firefox will save clipboard in private browsing

Before this patch, default home page of private sessions didn't inform about saving clipboard text. Now it informs that "copied text" will be saved in private session.

Comment 18

[Siddharth Maurya [:savvysiddharth]]

I've submitted changes, can you assign this to me?

Comment 19

[Josh Matthews [:jdm]]

Comment on attachment 9009360 [details]
Added firefox will save clipboard in private browsing

Josh Matthews [:jdm] has approved the revision.

Comment 20

[Josh Matthews [:jdm]]

As soon as my commit access is re-enabled I'll merge this. Thanks!

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0d3a741ff37c
Added firefox will save clipboard in private browsing r=jdm

Comment 22

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/0d3a741ff37c

Comment 23

[YF (Yang)]

The "copied text" sounds not including images, HTML, etc. I would rather it is the "Clipboard".

Comment 24

[Siddharth Maurya [:savvysiddharth]]

"Clipboard" seemed more appropriate to me as well, but I made changes according to things mentioned in comment 14, Can I make changes to the patch after it is closed?

Comment 25

[Mohammad Maruf Rahman]

I have reproduced  this bug with Nightly 60.0a1 (2018-03-02)on Windows 7, 64 Bit!
This bug's fix is verified with latest Nightly!

Build ID 	20180921100113
User Agent 	Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:64.0) Gecko/20100101 Firefox/64.0

Comment 26

[Josh Matthews [:jdm]]

I think the current text is fine. I'm not convinced that "clipboard" is a term in broad usage outside of developers.

Comment 27

[Siddharth Maurya [:savvysiddharth]]

(In reply to Josh Matthews [:jdm] from comment #26)
> I'm not convinced that "clipboard" is a term in broad usage outside of developers.

yeah, clipboard might be confusing for non-technical users 🤔