Closed Bug 1442862 Opened 7 years ago Closed 7 years ago

Dialog to update saved logins should have its own cancel button

Categories

(Firefox for iOS :: General, enhancement, P3)

Product:
Firefox for iOS
Component:
General
Platform:
Other
iOS
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
fxios 11.0 ---

People

(Reporter: flod, Assigned: is2ei)

Details

(Whiteboard: [GoodFirstBug])

Attachments

(1 file)

Pull request
55 bytes, text/x-github-pull-request
farhan
: review+
Details | Review
"Save login %1$@ for %2$@?" has two buttons: "Don't Save" and "Save Login". https://wopr.norad.org/~fxios/screenshots/fxios/v11/en-US/en-US/iPhone%208-17PasswordSnackbar-01.png "Update login %1$@ for %2$@?" has two buttons: "Don't Save" and "Update". https://wopr.norad.org/~fxios/screenshots/fxios/v11/en-US/en-US/iPhone%208-17PasswordSnackbar-02.png I think "Don't Save" in the second case should be "Don't Update", it looks quite confusing at the moment.
tracking-fxios: ? → 11.0
Priority: -- → P3
Whiteboard: [GoodFirstBug]
Hi, I'm Issei. Can I work on this issue?
Is this still open?
Flags: needinfo?(jdarcangelo)
Issei, yes this bug is still open. Robin, can you advise what the text should be here?
Flags: needinfo?(jdarcangelo) → needinfo?(randersen)
[Don't Update | Update] Thanks!
Flags: needinfo?(randersen)
Assignee: nobody → is2ei.horie
Attached file Pull request —
Thanks! I have created PR. Could you review it, please?
Attachment #8974700 - Flags: review?(jdarcangelo)
Attachment #8974700 - Flags: review?(jdarcangelo) → review+
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: