Closed Bug 1442906 Opened 3 years ago Closed 3 years ago

Port bug 1426362 to TB: Display status of policy engine in about:support

Categories

(Thunderbird :: General, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 60.0

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file)

Bug 1426362 added the display of the policy state. We don't use it, but add it to be in sync with FX.
Attached patch Policies.patchSplinter Review
This is only to be in sync with the m-c files. TB doesn't support the policies.

Actually about:support is broken until bug 1442866 lands.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8955805 - Flags: review?(acelists)
On current trunk just opening the Troubleshooting page crashes TB for me, in mozilla::EventTargetChainItem::HandleEvent(mozilla::EventChainPostVisitor&, mozilla::ELMCreationDetector&) (this=0x7f9d1d678008, aVisitor=..., aCd=...) .
Also https://dxr.mozilla.org/comm-central/source/mozilla/toolkit/modules/Troubleshoot.jsm#254 calls Services.policies.status without checking if Services.policies exists and it fails with a warning in the console. We should file that in Toolkit.
I tried, but fixing error that does not fix the crash.
(In reply to :aceman from comment #3)
> Also
> https://dxr.mozilla.org/comm-central/source/mozilla/toolkit/modules/
> Troubleshoot.jsm#254 calls Services.policies.status without checking if
> Services.policies exists and it fails with a warning in the console. We
> should file that in Toolkit.
> I tried, but fixing error that does not fix the crash.

This one is handled by bug 1442866.
(In reply to :aceman from comment #2)
> On current trunk just opening the Troubleshooting page crashes TB for me, in
> mozilla::EventTargetChainItem::HandleEvent(mozilla::EventChainPostVisitor&,
> mozilla::ELMCreationDetector&) (this=0x7f9d1d678008, aVisitor=..., aCd=...) .

No crash on current trunk on Linux Mint.
Comment on attachment 8955805 [details] [diff] [review]
Policies.patch

Do we really need to port this? As far as I know, Services.policies is null in TB, so you can't even test this. No need for a confusing no-op, I think.
We do this to have the files in sync...and maybe they decide sometime to move the policies to toolkit.
Comment on attachment 8955805 [details] [diff] [review]
Policies.patch

Review of attachment 8955805 [details] [diff] [review]:
-----------------------------------------------------------------

My Troubleshooting page suddenly no longer crashes TB (may also be due to updated Mesa driver, which I do often, and the page calls checks for OpenGL properties, with some warnings shown in console) so I can proceed here.
Seems to work fine, meaning no Policies table is shown for TB.
Thanks.
Attachment #8955805 - Flags: review?(acelists) → review+
Thanks.
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/fe09f771c2d3
Port bug 1426362 to TB: Display status of policy engine in about:support. r=aceman
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 60.0
You need to log in before you can comment on or make changes to this bug.